[padelsbach]

Description

The TLS 1.2 session ID required HAVE_SESSION_TICKET. This PR enables ID based resumption without ticket support.

Testing

Added unit tests

Checklist

• added tests
• updated/added doxygen
• updated appropriate READMEs
• Updated manual and documentation

[github-actions]

MemBrowse Memory Report · Explore what changed →

gcc-arm-cortex-m4-openssl-compat

• FLASH: .text -128 B (-0.0%, 796,124 B / 1,048,576 B, total: 76% used)

zephyr-frdm_rw612

• FLASH: log_const_area -8 B, rodata -8 B, text +1,600 B (+0.6%, 284,048 B / 67,108,864 B, total: 0% used)

No memory changes detected for:

• gcc-arm-cortex-m0plus
• gcc-arm-cortex-m3
• gcc-arm-cortex-m4
• gcc-arm-cortex-m4-baremetal
• gcc-arm-cortex-m4-crypto-only
• gcc-arm-cortex-m4-dtls13
• gcc-arm-cortex-m4-min-ecc
• gcc-arm-cortex-m4-pkcs7
• gcc-arm-cortex-m4-pq
• gcc-arm-cortex-m4-rsa-only
• gcc-arm-cortex-m4-sp-math
• gcc-arm-cortex-m4-tls12
• gcc-arm-cortex-m4-tls13
• gcc-arm-cortex-m7
• gcc-arm-cortex-m7-pq
• gcc-arm-cortex-m7-tls13
• stm32-sim-stm32h753

---

_{Catch memory regressions in CI with MemBrowse. Free for open source.}

[Copilot]

🟡 Changes recommended

Legacy ClientHello resumption bypasses the new security check, and the persisted cache version was not updated.

2 open findings

• Enforce SNI/ALPN binding on old-format ClientHello resumption · New
• Bump cache version for persisted session layout change · New

What changed in this PR

Extends SNI/ALPN validation to TLS 1.2 session-ID resumption without session tickets.

Changes:

• Stores SNI/ALPN hashes in all resumable sessions.
• Validates hashes during stateful resumption.
• Expands no-ticket regression-test coverage.

File	Description
wolfssl/​internal.h	Exposes session binding fields and helpers without tickets.
src/​internal.c	Enforces stateful resumption bindings.
src/​ssl_sess.c	Stores and serializes binding hashes.
tests/​api/​test_tls.c	Enables mismatch tests in no-ticket builds.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[wolfSSL-Fenrir-bot]

Fenrir Automated Review — PR #11738

Scan targets checked: wolfssl-src, wolfssl-bugs
Coverage: 4 of 4 in-scope changed file(s) opened by the reviewer

Fenrir result: Approved ✅

No new issues found in the changed files.

Advisory only — this automated result does not count as a GitHub approval.

Review tier: Lite

[Copilot]

🔵 Needs a closer look

Hashing failures can leave insecure stale bindings, and successful bound session-ID resumption lacks coverage.

0 open findings

2 resolved since last review

• Enforce SNI/ALPN binding on old-format ClientHello resumption
• Bump cache version for persisted session layout change

Previously missed (2)

In code that hasn't changed since last review

Handle hash failures before caching sessions

src/​ssl_sess.c:3933

These return values are discarded even though wc_Hash can fail (for example, WOLFSSL_SMALL_STACK returns MEMORY_E when its temporary allocation fails). The session is still cached, leaving a zero or stale binding; a later no-extension resumption can then match zero, or a reused session can remain bound to the previous SNI/ALPN. Treat a hash failure as a session-setup failure and do not cache/issue that session.

Avoid binding allocations when session resumption is unavailable

wolfssl/​internal.h:5258

These hashes are now allocated for every SNI/ALPN session even when NO_SESSION_CACHE is set and session tickets are absent, where no server resumption path can consume them. This unnecessarily enlarges each session by one or two digest sizes in the low-resource configuration. Gate the binding state and helpers on resumption being available (HAVE_SESSION_TICKET || !NO_SESSION_CACHE) as well as SNI/ALPN.

🧠 Review effort: Balanced

[philljj]

@claude review

[claude]

Findings marked 🟡 are optional suggestions and need no follow-up push.

[philljj]

Tests good with multi-test with gcc-c89, c89-clang-tidy, wolfssl-all, openssl-extra-coexist, tls13, dtls13, etc.

[philljj]

Tests good.

Please review Claude feedback, and consider commenting the #endif spaghetti in src/ssl_sess.c (some of the changes are difficult to interpret).

[philljj]

merge conflict