[dgarske]

Extends the WOLFSSL_PSOC6_CRYPTO port to Infineon PSOC Edge E8 (CAT1D), whose MXCRYPTO v2 engine runs the same PDL crypto core drivers, and fixes issues found bringing it up on KIT_PSE84_AI.

PSOC Edge support

• psoc6_crypto.h includes the PDL crypto core headers rather than cy_pdl.h, so a build needs only the crypto drivers.
• Buffers handed to the engine's FIFOs go through the PDL's CY_REMAP_ADDRESS_FOR_CRYPTO, so data in XIP flash (a code-bus alias) is reachable; AES-ECB on a constant input previously hung. This is the identity on PSoC6.
• NO_PSOC6_CRYPTO_ECC keeps ECDSA verify in software, for targets where the SP math assembly is faster.

Fixes (all PSoC6 targets)

• wc_Sha256Copy left the copy's hash_state pointing into the source's sha_buffers, so updating one context corrupted the other. It now re-initializes the copy with wc_Psoc6_Sha1_Sha2_Init(dst, ..., 0), as the other SHA-1/SHA-2 copy functions already do.
• wc_Psoc6_Aes_GcmDecrypt left the decrypted data in out on an authentication failure; it is now zeroed.
• The hardware ECDSA verify path skipped the digest length and all-zero hash checks; it now shares the input validation of the STM32 PKA path.

Testing

wolfCrypt test passes on KIT_PSE84_AI with the engine enabled, including AES-ECB with input in XIP flash. The touched files build against the PSoC6 PDL as before. Bare-metal example: wolfssl-examples embedded/infineon_psoc_e8.

[github-actions]

retest this please

[github-actions]

MemBrowse Memory Report

No memory changes detected for:

• gcc-arm-cortex-m0plus
• gcc-arm-cortex-m3
• gcc-arm-cortex-m4
• gcc-arm-cortex-m4-baremetal
• gcc-arm-cortex-m4-crypto-only
• gcc-arm-cortex-m4-dtls13
• gcc-arm-cortex-m4-min-ecc
• gcc-arm-cortex-m4-openssl-compat
• gcc-arm-cortex-m4-pkcs7
• gcc-arm-cortex-m4-pq
• gcc-arm-cortex-m4-rsa-only
• gcc-arm-cortex-m4-sp-math
• gcc-arm-cortex-m4-tls12
• gcc-arm-cortex-m4-tls13
• gcc-arm-cortex-m7
• gcc-arm-cortex-m7-pq
• gcc-arm-cortex-m7-tls13
• linuxkm-pie
• linuxkm-standard
• stm32-sim-stm32h753

[aidangarske]

Skoll Code Review

Scan type: review

Overall recommendation: REQUEST_CHANGES
Findings: 3 total — 3 posted, 0 skipped
3 finding(s) posted as inline comments (see file-level comments below)

Posted findings

• [High] PSoC Edge FIFO accesses omit required D-cache maintenance — wolfcrypt/src/port/cypress/psoc6_crypto.c:852-1052,1403-1484
• [High] Use the verification-specific digest-length minimum — wolfcrypt/src/ecc.c:10141
• [Medium] Enable the existing wipe-on-auth-failure test for PSoC — wolfcrypt/src/port/cypress/psoc6_crypto.c:2058-2061

Review generated by Skoll

[aidangarske]

Skoll Code Review

Scan type: review

Overall recommendation: REQUEST_CHANGES
Findings: 1 total — 1 posted, 0 skipped
1 finding(s) posted as inline comments (see file-level comments below)

Posted findings

• [High] Keep the legacy PSoC6 PDL buildable — wolfcrypt/src/port/cypress/psoc6_crypto.c:51

Review generated by Skoll

[mattia-moffa]

Looks good to me apart from the comment above by Aidan.