Repository navigation
Conversation
gasbytes
marked this pull request as ready for review
October 26, 2026 15:45
|
retest this please |
holtrop-wolfssl
requested changes
Oct 26, 2026
| return Err(rc); | ||
| } | ||
| } | ||
| Ok(()) |
Contributor
There was a problem hiding this comment.
This function just returns Ok(()) without doing anything with FIPS v5.2.3? That does not seem great. If it is still going to exist in that configuration, should it return an error instead?
Contributor
Author
There was a problem hiding this comment.
On v5.2.3 the FIPS settings turn RSA blinding off entirely, so there's nothing for the RNG to attach to and decryption doesn't need one, I think returning an error would only break callers, so it succeeds as a no-op.
But I think the comment can be a little bit more explicit, thanks.
gasbytes
force-pushed
the
rust-wrapper-fips-fixes-v5
branch
from
October 27, 2026 09:17
42b4e35 to
0cb812f
Compare
gasbytes
force-pushed
the
rust-wrapper-fips-fixes-v5
branch
from
October 27, 2026 09:56
0cb812f to
9dbe646
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extended the logic to handle the renaming of some functions for v5, used when the module exports a different symbol for the standard name, made sure it runs once per build and is cached. Added a layer around wc_HKDF_Extract (since wc_HKDF_Extract_ex doesn't exist on v5 modules) and wc_HKDF_Expand. Did the same for wc_rng_new.
Also did some module-specific gating and fixes, and updated some tests too.
Testing
Tested against the crate's testsuite and the rustls provider. On v5.2.3, wc_RsaPSS_VerifyCheck has no crate test and is only covered by the provider's tests.