Skip to content

Rust wrapper: implement the rand_core 0.9 RNG traits behind a rand_core_0_9 feature - #11910

Merged
holtrop-wolfssl merged 1 commit into
wolfSSL:masterfrom
gasbytes:rust-wrapper-rand-core-0-9
Oct 29, 2026
Merged

holtrop-wolfssl merged 1 commit into
wolfSSL:masterfrom
gasbytes:rust-wrapper-rand-core-0-9

Conversation

@gasbytes

@gasbytes gasbytes commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Adds an optional rand_core_0_9 feature so RNG implements the rand_core 0.9 TryRngCore and TryCryptoRng traits alongside the 0.10 ones, for users still on rand 0.9.

Copilot AI balanced review requested due to automatic review settings October 28, 2026 08:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@gasbytes gasbytes changed the title Rust wrapper: implement the rand_core 0.9 RNG traits behind a Rust wrapper: implement the rand_core 0.9 RNG traits behind a rand_core_0_9 feature Oct 28, 2026
@gasbytes gasbytes self-assigned this Oct 28, 2026
@gasbytes
gasbytes marked this pull request as ready for review October 28, 2026 09:05
@github-actions

Copy link
Copy Markdown

retest this please

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

@holtrop-wolfssl holtrop-wolfssl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look fine, but Cargo.lock was not updated to match. Can you add the updates there as well?

@gasbytes
gasbytes force-pushed the rust-wrapper-rand-core-0-9 branch from 6ed64f1 to 2da0c89 Compare October 29, 2026 09:49
@holtrop-wolfssl
holtrop-wolfssl merged commit 2badd22 into wolfSSL:master Oct 29, 2026
408 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants