Request
Right now the OutputHandler interface has two different flavours of write interface:
write(message); andwrite(message, bunch_of_metdata)
Guarded by the should_output_metadata function.
As discussed here, the write(message) interface is making our code more complicated, and likely doesn't have much if any performance benefit.
Pending some benchmarking to confirm that there isn't any meaningful performance difference, we should remove the write(message) interface as well as should_output_metadata.
Possible implementation
Simply delete the method from the interface as well as all derived classes, and remove all branches based on should_output_metadata.
Request
Right now the OutputHandler interface has two different flavours of write interface:
write(message); andwrite(message, bunch_of_metdata)Guarded by the
should_output_metadatafunction.As discussed here, the
write(message)interface is making our code more complicated, and likely doesn't have much if any performance benefit.Pending some benchmarking to confirm that there isn't any meaningful performance difference, we should remove the
write(message)interface as well asshould_output_metadata.Possible implementation
Simply delete the method from the interface as well as all derived classes, and remove all branches based on
should_output_metadata.