Repository navigation
Fix duplicate weighting in ROD geometric median - #746
Open
Himerometra wants to merge 1 commit into
Open
Himerometra wants to merge 1 commit into
Himerometra wants to merge 1 commit into
Conversation
Co-authored-by: Codex <noreply@openai.com>
Owner
|
Thank you for the analysis. On bundled data, weighting the geometric median by duplicate counts lowered ROD accuracy where duplicates are common. On cardio, ROC AUC fell from the 0.935 to 0.953 range to the 0.890 to 0.923 range, and average precision dropped by about 0.10. On shuttle, average precision dropped by 0.06 to 0.23 (3 to 5 seeds, one environment). These runs did not compare against the reference ROD code, so the deduplication may match it. I want to settle the reference-direction question in #726 first, and this pull request stays open until then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve sample multiplicities when calculating the geometric median in ROD. Deduplicating the input without retaining counts changes the minimization problem; for example, [0, 0, 0, 10, 20] incorrectly has the same median as [0, 10, 20].
Retain counts in the initialization and modified Weiszfeld updates. Add regression coverage for duplicates, translation, input order and degenerate inputs. Validation: 31 tests passed, including the existing ROD tests. Prepared with AI assistance and pending human review. No issue has been created yet.