Skip to content

#692: echo the argument back from the fake user - #711

Open
morphqdd wants to merge 1 commit into
zerocracy:masterfrom
morphqdd:692
Open

#692: echo the argument back from the fake user#711
morphqdd wants to merge 1 commit into
zerocracy:masterfrom
morphqdd:692

Conversation

@morphqdd

@morphqdd morphqdd commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Every user in offline mode came back with id: 444, so a judge storing
octo.user(id)[:id] wrote 444 for every contributor, and an id -> user -> id
round trip never returned the id it was given. A String argument came back with
login: nil, a shape the real API cannot produce, which breaks
user_name_by_id-style code.

An Integer comes back as :id now and a String as :login with a stable id from
name_to_number.

Closes #692

yegor256 commented Sep 4, 2026

Copy link
Copy Markdown
Member

CI is green and the change itself looks sound, but this PR now has merge conflicts with master (other PRs touching the same fake-GitHub-client test helpers were merged first). Flagging for manual review rather than merging as-is — please rebase onto current master and resolve the conflicts.


Generated by Claude Code

@yegor256
yegor256 self-requested a review September 4, 2026 06:12
# Conflicts:
#	test/fbe/test_octo.rb
@morphqdd

morphqdd commented Sep 5, 2026

Copy link
Copy Markdown
Contributor Author

@yegor256, no conflict here now. The branch is on top of current master (193def3), GitHub reports it mergeable, and all checks are green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fake client's user() returns id: 444 for everybody and login: nil for a login argument

2 participants