Adding remove_obsidian_comments postprocessor to remove obsidian format comments - #268
Open
Thompson-Jason wants to merge 9 commits into
Open
Thompson-Jason wants to merge 9 commits into
Thompson-Jason wants to merge 9 commits into
Conversation
Thompson-Jason
marked this pull request as draft
July 23, 2024 12:22
…ments postprocessor.
…md to be used in the README
Thompson-Jason
marked this pull request as ready for review
July 23, 2024 17:14
zoni
reviewed
Aug 3, 2024
zoni
left a comment
zoni
left a comment
Owner
There was a problem hiding this comment.
Thanks for picking this up! Here's some non-exhaustive, preliminary comments from a quick review. 😄
Let me know if any of this is unclear and needs more explanation
…g. Putting the Regex definition in a LazyCell. Adding logic to pop off codeblocks if they are inside a comment. Adding edge case to test.
…prove readability.
Thompson-Jason
marked this pull request as draft
August 6, 2024 20:46
Thompson-Jason
force-pushed
the
remove-comments
branch
from
August 7, 2024 02:43
a88139d to
e3aa83d
Compare
Thompson-Jason
marked this pull request as ready for review
August 7, 2024 02:44
Author
|
@zoni was there something more you felt this needed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding feature requested in issue #158 to remove Obsidian comments. As mentioned in PR #159 by @zoni I don't think it would be difficult to expand this postprocessor to instead of removing the comments making them HTML comments.