Skip to content

Publish C extension packages to PyPI only after the tests passed - #457

Merged
icemac merged 1 commit into
masterfrom
publish-after-tests
Oct 16, 2026
Merged

icemac merged 1 commit into
masterfrom
publish-after-tests

Conversation

@icemac

@icemac icemac commented Oct 16, 2026

Copy link
Copy Markdown
Member

The `publish` job of the c-code `tests.yml` only needed the build jobs, so the PyPI deployment could be approved while the tests were still running (e.g. https://github.com/zopefoundation/zope.interface/actions/runs/38692773465). It now also needs `test`, `docs` (if present) and `release-check`.

— Comment created by Claude

@icemac icemac self-assigned this Oct 16, 2026
@icemac
icemac requested a review from dataflake October 16, 2026 06:34
@icemac
icemac enabled auto-merge (squash) October 16, 2026 06:34
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 38861994181

Coverage increased (+0.4%) to 19.289%

Details

  • Coverage increased (+0.4%) from the base build.
  • Patch coverage: 9 of 9 lines across 1 file are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 1452
Covered Lines: 365
Line Coverage: 25.14%
Relevant Branches: 518
Covered Branches: 15
Branch Coverage: 2.9%
Branches in Coverage %: Yes
Coverage Strength: 0.25 hits per line

💛 - Coveralls

@dataflake dataflake left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea

@icemac
icemac merged commit a8e6b26 into master Oct 16, 2026
13 checks passed
@icemac
icemac deleted the publish-after-tests branch October 16, 2026 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants