Repository navigation
Conversation
zpao
added this pull request to stack #468
October 6, 2026 05:14
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The obsolete jest.config.js remains and references the removed ts-jest dependency.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Migrates the test suite from Jest to Vitest with jsdom.
Changes:
- Adds Vitest configuration and cleanup setup.
- Updates test imports, dependencies, scripts, and ESLint integration.
- Regenerates snapshots in Vitest format.
| File | Description |
|---|---|
vitest.setup.ts |
Registers post-test DOM cleanup. |
vitest.config.ts |
Configures Vitest with jsdom. |
src/__test__/index.test.tsx |
Replaces Jest imports with Vitest. |
src/__test__/__snapshots__/index.test.tsx.snap |
Converts snapshots to Vitest format. |
package.json |
Replaces Jest tooling and test script. |
eslint.config.mjs |
Replaces the Jest ESLint plugin with Vitest’s plugin. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| "publish-docs": "gh-pages --dist=examples --src='{index.html,iife/demo.js}'", | ||
| "serve:examples": "npx serve examples -l 3000", | ||
| "test": "jest", | ||
| "test": "vitest run", |
- Replace Jest with Vitest and jsdom. - Add Vitest config and setup; update test imports and scripts. - Remove unused jest-dom and use the Vitest ESLint plugin for tests. - Regenerate snapshots in Vitest format.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Stack created with GitHub Stacks CLI • Give Feedback 💬