Bugfix/update np2EigenVectorXd import path - #349
Merged
Merged
Conversation
LorenzzoQM
force-pushed
the
bugfix/update_np2EigenVectorXd_import_path
branch
from
July 28, 2026 20:06
0205362 to
fcb3c1d
Compare
Contributor
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
dhutererprats
approved these changes
Jul 28, 2026
dhutererprats
left a comment
dhutererprats
left a comment
Contributor
There was a problem hiding this comment.
Yes, looks correct and straightforward
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #348
Updates import path for
np2EigenVectorXdandnp2EigenMatrix3dto prevent deprecation warning while preserving backwards compatibility.Type of change
How should this pull request be reviewed?
How Has This Been Tested?
Passed unit and integration tests.
Checklist