Skip to content

Bugfix/update np2EigenVectorXd import path #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LorenzzoQM merged 2 commits into from
Jul 28, 2026
+10 −5
Merged

Bugfix/update np2EigenVectorXd import path #349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
029b648
[#348] Update np2Eigen import path
LorenzzoQM Jul 24, 2026
fcb3c1d
[#348] Update release notes
LorenzzoQM Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/source/release_notes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ Development - |version|
adding a new network architecture and example heuristics.
* Add a CI smoke test that builds and steps each benchmark environment. See issue #340.
* Update files for compatibility with Ruff 0.16.0's new default lint rules, excluding C408.
* Update ``np2EigenMatrix3d`` and ``np2EigenVectorXd`` import path to prevent deprecation warning while preserving compatibility with older versions of Basilisk.

Version 1.3.0
-------------
Expand Down
14 changes: 9 additions & 5 deletions src/bsk_rl/sim/dyn/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,13 @@
RigidBodyKinematics,
macros,
orbitalMotion,
unitTestSupport,
)

try:
from Basilisk.utilities.simHelpers import np2EigenMatrix3d, np2EigenVectorXd
except ImportError:
from Basilisk.utilities.unitTestSupport import np2EigenMatrix3d, np2EigenVectorXd

from bsk_rl.sim import world
from bsk_rl.utils import actuator_primitives as aP
from bsk_rl.utils.attitude import random_tumble
Expand Down Expand Up @@ -327,13 +331,13 @@ def setup_spacecraft_hub(
self.I_mat = [Ixx, 0.0, 0.0, 0.0, Iyy, 0.0, 0.0, 0.0, Izz]

self.scObject.hub.mHub = mass # kg
self.scObject.hub.IHubPntBc_B = unitTestSupport.np2EigenMatrix3d(self.I_mat)
self.scObject.hub.IHubPntBc_B = np2EigenMatrix3d(self.I_mat)

# Set the initial attitude and position
self.scObject.hub.sigma_BNInit = sigma_init
self.scObject.hub.omega_BN_BInit = omega_init
self.scObject.hub.r_CN_NInit = unitTestSupport.np2EigenVectorXd(rN)
self.scObject.hub.v_CN_NInit = unitTestSupport.np2EigenVectorXd(vN)
self.scObject.hub.r_CN_NInit = np2EigenVectorXd(rN)
self.scObject.hub.v_CN_NInit = np2EigenVectorXd(vN)

self.simulator.AddModelToTask(
self.task_name, self.scObject, ModelPriority=priority
Expand Down Expand Up @@ -698,7 +702,7 @@ def setup_solar_panel(
self.world.gravFactory.spiceObject.planetStateOutMsgs[self.world.sun_index]
)
self.solarPanel.setPanelParameters(
unitTestSupport.np2EigenVectorXd(nHat_B),
np2EigenVectorXd(nHat_B),
panelArea,
panelEfficiency,
)
Expand Down
Loading