fix(otel): correct trace metric status and endpoint coverage - #7573
Merged
Conversation
Require explicit OK status for successful trace metrics and use stable endpoint generation while keeping unmerged Python support gated. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
|
link04
marked this pull request as draft
August 25, 2026 02:08
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ba908fd7d3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
marcotc
approved these changes
Aug 25, 2026
marcotc
marked this pull request as ready for review
August 25, 2026 21:07
Keep language-specific request paths out of shared test logic while preserving existing tracer activation gates. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Aug 25, 2026
cbeauchesne
approved these changes
Aug 26, 2026
link04
enabled auto-merge (squash)
August 27, 2026 04:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
STATUS_CODE_OKon successful OTLP trace metrics, while keeping Python gated until the corresponding libdatadog support mergeshttp.endpointthrough stable resource-renaming requests for Node.js, Python, and GoTest plan
otel-aspnetcoreimage: routed AppSec endpoint-retention test passes over direct OTLP./format.shreaches shellcheck after all checks above pass, then hits the existing macOS Bash 3 empty-array failure inutils/scripts/shellcheck.sh(@: unbound variable).Made with Cursor