Skip to content

fix(otel): correct trace metric status and endpoint coverage - #7573

Merged
link04 merged 3 commits into
mainfrom
maximo/otel-semantics-system-tests-v3
Aug 27, 2026
Merged

fix(otel): correct trace metric status and endpoint coverage#7573
link04 merged 3 commits into
mainfrom
maximo/otel-semantics-system-tests-v3

Conversation

@link04

@link04 link04 commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • require STATUS_CODE_OK on successful OTLP trace metrics, while keeping Python gated until the corresponding libdatadog support merges
  • generate http.endpoint through stable resource-renaming requests for Node.js, Python, and Go
  • use a routed AppSec request for .NET so the same retention assertion is valid
  • enable simplified endpoint generation only in the OTLP HTTP-semantics scenario

Test plan

  • Node.js OTel branch: endpoint-retention test passes over direct OTLP
  • Python OTel branch: endpoint-retention test passes over direct OTLP
  • .NET otel-aspnetcore image: routed AppSec endpoint-retention test passes over direct OTLP
  • Go main: endpoint-retention test passes over direct OTLP
  • Ruff formatting/lint and mypy pass
  • YAML formatting, lint, and manifest parser checks pass

./format.sh reaches shellcheck after all checks above pass, then hits the existing macOS Bash 3 empty-array failure in utils/scripts/shellcheck.sh (@: unbound variable).

Made with Cursor

Require explicit OK status for successful trace metrics and use stable endpoint generation while keeping unmerged Python support gated.

Co-authored-by: Cursor <cursoragent@cursor.com>
@link04
link04 requested review from a team as code owners August 25, 2026 02:04
@github-actions

github-actions Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

manifests/dotnet.yml                                                    @DataDog/system-tests-reviewers
manifests/golang.yml                                                    @DataDog/system-tests-reviewers
manifests/java.yml                                                      @DataDog/system-tests-reviewers
manifests/nodejs.yml                                                    @DataDog/system-tests-reviewers
manifests/php.yml                                                       @DataDog/system-tests-reviewers
manifests/python.yml                                                    @DataDog/system-tests-reviewers
manifests/ruby.yml                                                      @DataDog/system-tests-reviewers
manifests/rust.yml                                                      @DataDog/system-tests-reviewers
tests/test_otel_http_semantics.py                                       @DataDog/system-tests-core
utils/_context/_scenarios/__init__.py                                   @DataDog/system-tests-core

@link04
link04 marked this pull request as draft August 25, 2026 02:08

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ba908fd7d3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/test_otel_http_semantics.py Outdated
Comment thread tests/test_otel_http_semantics.py
Comment thread utils/_context/_scenarios/__init__.py
@datadog-official

datadog-official Bot commented Aug 25, 2026

Copy link
Copy Markdown

Pipelines  Tests

⚠️ Warnings

⚠️ Your PR has warnings. Please review the issues below.

🚦 1 Pipeline job failed

Testing the test | all-jobs-are-green

View more details · View in GitHub Actions

Job did not run: blocked by a failed job in an earlier pipeline stage.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 907aadb | Docs | View more details | Give us feedback!

@marcotc
marcotc marked this pull request as ready for review August 25, 2026 21:07
link04 and others added 2 commits August 25, 2026 17:23
Keep language-specific request paths out of shared test logic while preserving existing tracer activation gates.

Co-authored-by: Cursor <cursoragent@cursor.com>
@link04
link04 enabled auto-merge (squash) August 27, 2026 04:58
@link04
link04 merged commit b632a00 into main Aug 27, 2026
3553 of 3558 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants