Skip to content

Quiet MAPL logging in the FV3 regression cases - #445

Merged
pchakraborty merged 1 commit into
release/MAPL-v3from
feature/pchakrab/regression-logging
Nov 10, 2026
Merged

pchakraborty merged 1 commit into
release/MAPL-v3from
feature/pchakrab/regression-logging

Conversation

@pchakraborty

Copy link
Copy Markdown
Collaborator

Logging

Adds a logging.yaml to the three regression cases (adv-dyn, adv-sa, dyn-sa) and loads it from mapl.yaml with a top-level pflogger: logging.yaml. It sends logs to the console only, sets the MAPL logger to ERROR and keeps MAPL.profiler at INFO on the root rank, so the timing report is still printed.

The cases run without a field dictionary, so MAPL warns once per variable spec per rank, and its default logging writes each warning to warnings_and_errors.log under an MPI lock, which serializes the ranks. The same file is being added to the regression cases in GOCART (GEOS-ESM/GOCART#501), GEOSgcm_GridComp (GEOS-ESM/GEOSgcm_GridComp#1574) and GEOSradiation_GridComp (GEOS-ESM/GEOSradiation_GridComp#116); the PRs are independent.

AGENTS.md

Adds the MAPL3 error-macro rule (_RC, _STAT, _ASSERT with a message, _RETURN(_SUCCESS); _RC cannot end a one-line if; no !---- separators).

Testing

ctest -L REGRESSION (ifx Debug): 32/32 pass with the logging files in every GEOS case directory. The GEOS cases' summed test time went from 189 s to 132 s.

Each case directory gets a logging.yaml (console output only, MAPL logger at ERROR) that mapl.yaml loads with `pflogger: logging.yaml`. Without a field dictionary MAPL warns once per variable spec per rank, and its default logging writes each warning to warnings_and_errors.log under an MPI lock, which serializes the ranks. AGENTS.md: add the MAPL3 error-macro rule.
@pchakraborty
pchakraborty merged commit 4d7c4a3 into release/MAPL-v3 Nov 10, 2026
23 checks passed
@pchakraborty
pchakraborty deleted the feature/pchakrab/regression-logging branch November 10, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0 diff The changes in this pull request have verified to be zero-diff with the target branch. MAPL3 MAPL 3 Related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants