Repository navigation
Quiet MAPL logging in the radiation regression cases; record their run time - #116
Merged
pchakraborty merged 1 commit intoNov 10, 2026
Merged
Conversation
…n time Each case directory gets a logging.yaml (console output only, MAPL logger at ERROR) that mapl.yaml loads with `pflogger: logging.yaml`. Without a field dictionary MAPL warns once per variable spec per rank, and its default logging writes each warning to warnings_and_errors.log under an MPI lock, which serializes the ranks. The regression README records the cases run times, dominated by RRTMGP built with Debug flags. AGENTS.md: add the MAPL3 error-macro rule.
pchakraborty
marked this pull request as ready for review
November 10, 2026 03:06
This was referenced Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logging
Adds a
logging.yamlto the four regression cases (irrad-sa,solar-sa,satsim-sa,radiation) and loads it frommapl.yamlwith a top-levelpflogger: logging.yaml. It sends logs to the console only, sets theMAPLlogger to ERROR and keepsMAPL.profilerat INFO on the root rank, so the timing report is still printed.The cases run without a field dictionary, so MAPL warns once per variable spec per rank, and its default logging writes each warning to
warnings_and_errors.logunder an MPI lock, which serializes the ranks. The same file is being added to the GOCART (GEOS-ESM/GOCART#501), GEOSgcm_GridComp (GEOS-ESM/GEOSgcm_GridComp#1574) and FVdycoreCubed_GridComp (GEOS-ESM/FVdycoreCubed_GridComp#445) regression cases; the PRs are independent.Run time
regression/README.mdgets a "Run time" section. Unlike the Moist cases, these tests are dominated by RRTMGP, not by MAPL: one LW call takes about 5.3 s and one SW call about 5.5 s on ~144 columns per rank, because RRTMGP is built with the full Debug flags (-O0 -check all -init=snan,arrays ...).radiation(17 s) is roughlyirrad-saplussolar-saplus COSP. The section lists two options, not done here: build RRTMGP with-check noneat-O0(expected zero-diff, to be verified), or optimize it (changes answers, so the baselines would have to be regenerated).AGENTS.md
Adds the MAPL3 error-macro rule (
_RC,_STAT,_ASSERTwith a message,_RETURN(_SUCCESS);_RCcannot end a one-lineif; no!----separators).Testing
ctest -L REGRESSION(ifx Debug): 32/32 pass with the logging files in every GEOS case directory. The times in the README are from that run's MAPL profiler output.