Skip to content

Quiet MAPL logging in the radiation regression cases; record their run time - #116

Merged
pchakraborty merged 1 commit into
release/MAPL-v3from
feature/pchakrab/regression-logging
Nov 10, 2026
Merged

pchakraborty merged 1 commit into
release/MAPL-v3from
feature/pchakrab/regression-logging

Conversation

@pchakraborty

@pchakraborty pchakraborty commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Logging

Adds a logging.yaml to the four regression cases (irrad-sa, solar-sa, satsim-sa, radiation) and loads it from mapl.yaml with a top-level pflogger: logging.yaml. It sends logs to the console only, sets the MAPL logger to ERROR and keeps MAPL.profiler at INFO on the root rank, so the timing report is still printed.

The cases run without a field dictionary, so MAPL warns once per variable spec per rank, and its default logging writes each warning to warnings_and_errors.log under an MPI lock, which serializes the ranks. The same file is being added to the GOCART (GEOS-ESM/GOCART#501), GEOSgcm_GridComp (GEOS-ESM/GEOSgcm_GridComp#1574) and FVdycoreCubed_GridComp (GEOS-ESM/FVdycoreCubed_GridComp#445) regression cases; the PRs are independent.

Run time

regression/README.md gets a "Run time" section. Unlike the Moist cases, these tests are dominated by RRTMGP, not by MAPL: one LW call takes about 5.3 s and one SW call about 5.5 s on ~144 columns per rank, because RRTMGP is built with the full Debug flags (-O0 -check all -init=snan,arrays ...). radiation (17 s) is roughly irrad-sa plus solar-sa plus COSP. The section lists two options, not done here: build RRTMGP with -check none at -O0 (expected zero-diff, to be verified), or optimize it (changes answers, so the baselines would have to be regenerated).

AGENTS.md

Adds the MAPL3 error-macro rule (_RC, _STAT, _ASSERT with a message, _RETURN(_SUCCESS); _RC cannot end a one-line if; no !---- separators).

Testing

ctest -L REGRESSION (ifx Debug): 32/32 pass with the logging files in every GEOS case directory. The times in the README are from that run's MAPL profiler output.

…n time

Each case directory gets a logging.yaml (console output only, MAPL logger at ERROR) that mapl.yaml loads with `pflogger: logging.yaml`. Without a field dictionary MAPL warns once per variable spec per rank, and its default logging writes each warning to warnings_and_errors.log under an MPI lock, which serializes the ranks. The regression README records the cases run times, dominated by RRTMGP built with Debug flags. AGENTS.md: add the MAPL3 error-macro rule.
@pchakraborty pchakraborty added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Nov 10, 2026
@pchakraborty
pchakraborty marked this pull request as ready for review November 10, 2026 03:06
@pchakraborty
pchakraborty requested a review from a team as a code owner November 10, 2026 03:06
@pchakraborty
pchakraborty merged commit 856688c into release/MAPL-v3 Nov 10, 2026
14 checks passed
@pchakraborty
pchakraborty deleted the feature/pchakrab/regression-logging branch November 10, 2026 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0 diff The changes in this pull request have verified to be zero-diff with the target branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant