Repository navigation
Extract ganesh into separate module - #1301
Open
Hubert Błaszczyk (hub-bla) wants to merge 34 commits into
Open
Hubert Błaszczyk (hub-bla) wants to merge 34 commits into
Hubert Błaszczyk (hub-bla) wants to merge 34 commits into
Conversation
Hubert Błaszczyk (hub-bla)
requested review from
Ivan Matkov (MatkovIvan) and
Igor Demin (igordmn)
September 16, 2026 11:25
Contributor
|
Please, test in Compose first, before merging |
Contributor
Author
|
I already did it locally but I'll definitely create a PR in Compose with all the necessary changes before merging this one |
Hubert Błaszczyk (hub-bla)
force-pushed
the
hub.bla/skiko-ganesh-module
branch
2 times, most recently
from
September 21, 2026 12:42
e4590c2 to
97b2988
Compare
Hubert Błaszczyk (hub-bla)
force-pushed
the
hub.bla/skiko-ganesh-module
branch
from
September 30, 2026 09:04
4a1e000 to
920e1cc
Compare
Igor Demin (igordmn)
self-requested a review
October 5, 2026 13:48
Hubert Błaszczyk (hub-bla)
force-pushed
the
hub.bla/skiko-ganesh-module
branch
from
October 6, 2026 07:11
920e1cc to
5b68a17
Compare
Hubert Błaszczyk (hub-bla)
force-pushed
the
hub.bla/skiko-ganesh-module
branch
from
October 6, 2026 08:38
5b68a17 to
9166928
Compare
Hubert Błaszczyk (hub-bla)
force-pushed
the
hub.bla/skiko-ganesh-module
branch
from
October 7, 2026 07:10
9166928 to
1182d1d
Compare
Contributor
|
Everything LGTM, only #1301 (comment) needs to be resolved by my review. Before merging, needs to be checked in Compose again |
Hubert Błaszczyk (hub-bla)
force-pushed
the
hub.bla/skiko-ganesh-module
branch
from
October 27, 2026 12:43
1182d1d to
c531935
Compare
Hubert Błaszczyk (hub-bla)
force-pushed
the
hub.bla/skiko-ganesh-module
branch
from
October 27, 2026 13:14
c531935 to
cfe1c41
Compare
Igor Demin (igordmn)
requested changes
Oct 28, 2026
Hubert Błaszczyk (hub-bla)
force-pushed
the
hub.bla/skiko-ganesh-module
branch
from
October 29, 2026 09:13
97d7246 to
22244a2
Compare
Igor Demin (igordmn)
approved these changes
Oct 29, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extracts Ganesh GPU backend support from the core skiko module into a new
skiko-ganeshmodule.Consumers using Ganesh APIs will need to add the
skiko-ganeshdependency and update imports for APIs moved toorg.jetbrains.skia.gpu.ganeshFixes SKIKO-1190