[#515] Fix Club team application links

[ChrisH0125]

Why

Team application cards on the Club Teams page linked to Blade using
/forms/<slug>, which returns a Not Found page. Blade’s public form route is
/form/<slug>. Basically, true URL should be form/{form} not forms/{form}

What

Closes: #515

Updated the shared team-application URL builder to use Blade’s singular
/form/<slug> route, singular line change

Added regression coverage for Sponsorship, Workshop, Design, Outreach, and
Development application links. Ngl it should probably be in its own .tsx since the name of the file could be misleading for these tests as this fix does not necessarily mean "skeleton-loading"

Test Plan

• Ran pnpm --filter=@forge/club test — 9 tests passed.
• Ran pnpm analyze:react:changed — passed.
• Ran pnpm verify:precommit — passed; existing repository lint warnings remain.
• Started Club locally and clicked every application card from
  http://localhost:3001/teams.
• Confirmed every card opens its corresponding Blade form instead of a Not
  Found page.

Checklist

• Database: No schema changes.
• Environment Variables: No environment variables changed.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: QUIET

Plan: Pro Plus

Run ID: 3dc29efd-cec8-430f-a522-86b1b7437fbd

📥 Commits

Reviewing files that changed from the base of the PR and between 2ff8cc8 and f7d6591.

📒 Files selected for processing (2)

• apps/club/src/app/teams/teams-client.tsx
• apps/club/src/tests/team-roster-skeleton.test.tsx

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

getFormHref now generates application URLs with the singular /form/{slug} path. Tests verify that TeamsClient renders the expected singular route for each configured application slug and does not render plural /forms/ routes.

Merge Risk: ⚪ Minimal · up to f7d65

The change updates Club team application links to the correct form route and adds coverage for the affected teams; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 7 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (7 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title starts with [#515], describes the team application link fix, and is 38 characters long.
Description check	✅ Passed	The description explains the incorrect /forms/ route, the /form/ fix, regression coverage, and validation steps.
Linked Issues check	✅ Passed	The changes update the shared URL builder to use /form/ and add regression coverage that checks configured application links and rejects /forms/. Existing URL encoding remains unchanged.
Out of Scope Changes check	✅ Passed	The URL builder change and focused regression test directly support issue #515. No unrelated code, schema, or environment changes are included.
No Hardcoded Secrets	✅ Passed	The pull request adds only the /form/ route, application slugs, and a localhost test URL. No hardcoded API keys, passwords, tokens, or secrets appear in the changed files or added diff lines.
Validated Env Access	✅ Passed	The pull request introduces no direct process.env usage. The diff only changes the form URL path and adds URL assertions; neither changed file contains process.env. Existing references elsewhere a…
No Typescript Escape Hatches	✅ Passed	The pull-request diff adds no any type, @ts-ignore, @ts-expect-error, or non-null assertion. Structural searches found no as any or non-null assertions in either changed TypeScript file. The o…

Full details: Validated Env Access

Explanation

The pull request introduces no direct process.env usage. The diff only changes the form URL path and adds URL assertions; neither changed file contains process.env. Existing references elsewhere are outside the pull request and do not satisfy the causal failure condition.

Full details: No Typescript Escape Hatches

Explanation

The pull-request diff adds no any type, @ts-ignore, @ts-expect-error, or non-null assertion. Structural searches found no as any or non-null assertions in either changed TypeScript file. The only source change is the /form/ route update, and the added test uses ordinary typed TypeScript.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

Some tools did not complete. Review the errors below.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

apps/club/src/app/teams/teams-client.tsx

ESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox.

apps/club/src/tests/team-roster-skeleton.test.tsx

ESLint skipped: the matched ESLint configuration already failed (missing-dependency).

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[DVidal1205]

lgtm