Skip to content

[#515] Fix Club team application links #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DVidal1205 merged 1 commit into from
Aug 25, 2026
Merged

[#515] Fix Club team application links #516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/club/src/app/teams/teams-client.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ const TEAM_APPLICATIONS = [
] as const;

function getFormHref(bladeUrl: string, slug: string) {
return new URL(`/forms/${encodeURIComponent(slug)}`, bladeUrl).toString();
return new URL(`/form/${encodeURIComponent(slug)}`, bladeUrl).toString();
}

function getInitials(name: string) {
Expand Down
17 changes: 17 additions & 0 deletions apps/club/src/tests/team-roster-skeleton.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,21 @@ describe("team roster loading placeholders", () => {
expect(html).not.toContain('aria-label="Team filters"');
expect(html).toContain("Loading team members");
});

it("links team applications to Blade's singular form route", () => {
const html = renderToStaticMarkup(
createElement(TeamsClient, { bladeUrl: "http://localhost:3000" }),
);

for (const slug of [
"sponsorship-team-application",
"workshop-team-application",
"design-team-applications",
"outreach-team-applications",
"dev-team-applications",
]) {
expect(html).toContain(`href="http://localhost:3000/form/${slug}"`);
}
expect(html).not.toContain("/forms/");
});
});