Replay pre-frame blocks before the first FrameBegin - #3257
Open
antonio-lunarg wants to merge 2 commits into
Open
antonio-lunarg wants to merge 2 commits into
antonio-lunarg wants to merge 2 commits into
Conversation
antonio-lunarg
requested review from
bradgrantham-lunarg,
charles-lunarg and
jzulauf-lunarg
as code owners
September 9, 2026 12:08
antonio-lunarg
force-pushed
the
antonio-pre-frame-boundary
branch
2 times, most recently
from
September 9, 2026 12:10
696b1de to
c480cb8
Compare
antonio-lunarg
added
the
approved-to-run-ci
nickdriscoll-lunarg
left a comment
nickdriscoll-lunarg
left a comment
Contributor
There was a problem hiding this comment.
Just some nitpicks. Looks pretty good overall!
antonio-lunarg
force-pushed
the
antonio-pre-frame-boundary
branch
from
September 9, 2026 13:26
c480cb8 to
5a80867
Compare
antonio-lunarg
force-pushed
the
antonio-pre-frame-boundary
branch
from
September 11, 2026 08:36
5a80867 to
af79304
Compare
BlockProcessor::ProcessBlocks() returns kPreFrameBoundary once, before the first block that belongs to frame 0. It peeks the next block header and treats leading meta, annotation, and state marker blocks, and every block inside a state block, as pre-frame. FileProcessor::ProcessPreFrame() replays up to that boundary, and Application::Run() calls it once before the frame loop. A trimmed capture's state setup now runs before FrameBegin 0, so its queue submits emit no plugin events and the first frame interval holds only frame work. Full captures replay the same blocks in the same order, only the two leading meta blocks move ahead of FrameBegin 0.
antonio-lunarg
force-pushed
the
antonio-pre-frame-boundary
branch
from
September 24, 2026 13:29
af79304 to
3d1a25b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BlockProcessor::ProcessBlocks()returnskPreFrameBoundaryonce, before the first block that belongs to frame 0. It peeks the next block header and treats leading meta, annotation, and state marker blocks, and every block inside a state block, as pre-frame.FileProcessor::ProcessPreFrame()replays up to that boundary, andApplication::Run()calls it once before the frame loop.A trimmed capture's state setup now runs before FrameBegin 0, so its queue submits emit no plugin events and the first frame interval holds only frame work.
Full captures replay the same blocks in the same order, only the two leading meta blocks move ahead of FrameBegin 0.