Add retries to clones - #3307
Conversation
bradgrantham-lunarg
left a comment
There was a problem hiding this comment.
Looks good.
I think you've uncovered a bug in the previous retry/try/catch idioms; I think they should also throw in their catch blocks, so that can be a subsequent PR if you are motivated.
I think you're referring to the cleanWs retry? You're right that it isn't actually retrying, and should get fixed. However, it can't be the same pattern exactly. We don't want a successful test to fail because the post-cleanup failed. There is still a pre-cleanup that will trigger next go around. But we should fix that retry. Because its a little different, I've created a new-issue for it: |
No description provided.