Skip to content

Add retries to clones - #3307

Merged
beau-lunarg merged 1 commit into
LunarG:devfrom
beau-lunarg:beau-projects-1236
Sep 30, 2026
Merged

beau-lunarg merged 1 commit into
LunarG:devfrom
beau-lunarg:beau-projects-1236

Conversation

@beau-lunarg

Copy link
Copy Markdown
Contributor

No description provided.

@beau-lunarg beau-lunarg added the approved-to-run-ci Can run CI check on internal LunarG machines label Sep 29, 2026

@bradgrantham-lunarg bradgrantham-lunarg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I think you've uncovered a bug in the previous retry/try/catch idioms; I think they should also throw in their catch blocks, so that can be a subsequent PR if you are motivated.

@beau-lunarg

Copy link
Copy Markdown
Contributor Author

Looks good.

I think you've uncovered a bug in the previous retry/try/catch idioms; I think they should also throw in their catch blocks, so that can be a subsequent PR if you are motivated.

I think you're referring to the cleanWs retry? You're right that it isn't actually retrying, and should get fixed. However, it can't be the same pattern exactly. We don't want a successful test to fail because the post-cleanup failed. There is still a pre-cleanup that will trigger next go around. But we should fix that retry. Because its a little different, I've created a new-issue for it:

https://github.com/LunarG/Projects/issues/1243

@beau-lunarg
beau-lunarg added this pull request to the merge queue Sep 30, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 30, 2026
@beau-lunarg
beau-lunarg added this pull request to the merge queue Sep 30, 2026
Merged via the queue into LunarG:dev with commit e79c425 Sep 30, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-to-run-ci Can run CI check on internal LunarG machines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants