Conversation
…username characters error
There was a problem hiding this comment.
⚠️ Not ready to approve
The new username validation check is currently brittle (exact-match + first-element only) and can still surface the wrong toast depending on API error ordering/wording.
Pull request overview
This PR adjusts the registration error-toasting logic in RegisterPage.vue so that an “invalid username characters” backend validation error no longer shows the “username already taken” message.
Changes:
- Adds a dedicated error toast element at the top of the register page content.
- Renames and updates the register error handler to map an “invalid characters” username error to a correct French message.
File summaries
| File | Description |
|---|---|
| src/views/RegisterPage.vue | Updates the registration error-message mapping and toast wiring to show a more accurate username validation message. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Low
Note
Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.
chrislng
self-requested a review
July 28, 2026 06:18
chrislng
approved these changes
Jul 28, 2026
chrislng
deleted the
feature/register-page-username-invalid-characters-error-message
branch
July 28, 2026 06:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…username characters error
Pull Request
Summary
Put correct error message
Changes Made
Screenshots (if applicable)
Related Issues
Checklist
Please ensure all the following steps are completed before submitting the pull request:
Additional Notes