Skip to content

Correction: wrong error message (username already taken) for invalid … - #313

Merged
chrislng merged 1 commit into
devfrom
feature/register-page-username-invalid-characters-error-message
Jul 28, 2026
Merged

chrislng merged 1 commit into
devfrom
feature/register-page-username-invalid-characters-error-message

Conversation

@SarahHCode

Copy link
Copy Markdown
Collaborator

…username characters error

Pull Request

Summary

Put correct error message

Changes Made

Screenshots (if applicable)

image

Related Issues

Checklist

Please ensure all the following steps are completed before submitting the pull request:

  • Code passes all existing tests
  • New features or changes are accompanied by appropriate tests
  • Code follows the established coding style and conventions
  • Documentation has been updated to reflect the changes (if applicable)
  • All new and existing tests pass locally

Additional Notes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Not ready to approve

The new username validation check is currently brittle (exact-match + first-element only) and can still surface the wrong toast depending on API error ordering/wording.

Pull request overview

This PR adjusts the registration error-toasting logic in RegisterPage.vue so that an “invalid username characters” backend validation error no longer shows the “username already taken” message.

Changes:

  • Adds a dedicated error toast element at the top of the register page content.
  • Renames and updates the register error handler to map an “invalid characters” username error to a correct French message.
File summaries
File Description
src/views/RegisterPage.vue Updates the registration error-message mapping and toast wiring to show a more accurate username validation message.

Review details

  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Low

Note

Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.

Comment thread src/views/RegisterPage.vue
@chrislng
chrislng self-requested a review July 28, 2026 06:18
@chrislng
chrislng merged commit ce652d2 into dev Jul 28, 2026
1 check passed
@chrislng
chrislng deleted the feature/register-page-username-invalid-characters-error-message branch July 28, 2026 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants