Skip to content

Correction: wrong error message (username already taken) for invalid … #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrislng merged 1 commit into from
Jul 28, 2026
Merged

Correction: wrong error message (username already taken) for invalid … #313

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions src/views/RegisterPage.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
<template>
<ion-page>
<ion-content :fullscreen="true">

<!-- Error message toast -->
<ion-toast
class="error-toast"
:is-open="ionToastErrorMessageIsOpen"
:message="ionToastErrorMessage"
:duration="9000"
Expand Down Expand Up @@ -167,7 +170,7 @@ export default {
this.$router.replace("/loading");
} else {
// Show appropriate error
this.handleError(parsed);
this.handleRegisterPageErrorMessage(parsed);
}
})

Expand All @@ -177,17 +180,28 @@ export default {
}
},

handleError(parsed) {
handleRegisterPageErrorMessage(parsed) {

const passwordTooShortMessage =
"Le mot de passe doit être d'au moins 6 caractères.\n";
const passwordsNotMatchingMessage =
"Les mots de passe ne concordent pas.\n";
const usernameTakenMessage = "Le nom d'utilisateur·rice est déjà pris.\n";
const usernameInvalidCharactersMessage_inFrench =
"Le nom d'utilisateur·rice ne peut contenir que des lettres,\ndes chiffres, des tirets et des tirets bas.\n";
const emailTakenMessage = "Le courriel est déjà pris.\n";

if (parsed.errors) {
let ionToastErrorMessage = "";
if (parsed.errors.username)

if (parsed.errors.username
&& parsed.errors.username[0] === "The username may only contain letters, numbers, dashes and underscores.") {
ionToastErrorMessage += usernameInvalidCharactersMessage_inFrench;
}
else if (parsed.errors.username) {
Comment thread
chrislng marked this conversation as resolved.
ionToastErrorMessage += usernameTakenMessage;
}

if (parsed.errors.password) {
// API response returns "The password must be at least 6 characters." and "The password confirmation does not match."
if (parsed.errors.password.length === 2) {
Expand All @@ -203,10 +217,12 @@ export default {
: passwordsNotMatchingMessage;
}
}

if (parsed.errors.email) ionToastErrorMessage += emailTakenMessage;

this.showAlert(ionToastErrorMessage);
}

},

showAlert(alertMessage) {
Expand Down