Repository navigation
test(e2e): merge and trim the Rust integration tests - #14145
Merged
Merged
Conversation
Merge the two sandbox startup failure tests and the two Fabric start failure tests, drop the search-scope export test and the scoped provider label test that SDK and CLI unit tests own, and trim the export, credential, interrupted-create, failed-first-apply, CLI output, and redaction tests to what needs a real bundle. Refs #14060 Signed-off-by: San Dang <sdang@nvidia.com>
Collaborator
Author
Authoring session — opening
|
Contributor
|
v1 documentation preview: https://nvidia-preview-nemoclaw-v1-pr-14145.docs.buildwithfern.com/nemoclaw |
This was referenced Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failure
The Rust integration tests in
crates/nemoclaw-e2e/tests/integration/rust/repeated checks that other tests own. Two pairs tested the same failure, and several tests compared outputs or exports that SDK or CLI unit tests already cover. This is section 3 of the duplicated-checks list on #14060.Part of #14060.
Decision
deployment::startup_and_observation_failures…+sandbox_startup_failure_names_reason…a_sandbox_startup_failure_is_reported_safely_retained_and_recovered: the CLI's JSON report and plan, the unfinished-apply guard, the retry, recovery, failed and cut-off observations, and a lost deletedeployment::failed_first_configuration…+fabric_deployment::failed_configuration…fabric_deployment::a_rejected_start_is_reported_safely_and_a_corrected_document_replaces_the_sandboxexport_observations::mixed_search_export…export_preserves_search_definitions_and_rejects_registration_drift,export_requires_shared_definition_registrations_to_agree_on_credentials, and the drift table inauthored_settings_survive_cli_export…deployment::scoped_provider_labels…inline_and_scoped_provider_sources_preserve_authored_names_without_valuesand CLIresource_results_name_authored_sources_and_separate_deferred_workexport_observations::export_refreshes…export_skips_gateway_readiness_and_changes_nothingexport_observations::credentialed_inference…a_credentialed_deployment_exports_and_tears_down_without_its_secretexport_updates_only_the_observed_provider_definition. No probes:kubernetes-external-three-agentsdeployment::interrupted_create…deployment::failed_first_apply…deployment::cli_terminal_outputs…deployment::cli_redaction…cli_redaction_withholds_short_and_colliding_credentials, without the recovery tailKept unchanged after checking:
fabric_deployment::missing_runtime_declaration…: the SDK'sunfinished_apply_without_complete_runtime_state_explains_how_to_recoverchecks a different case, a record whose apply is unfinished.deployment::rejected_policy…: the SDK'ssandbox_admissiontests check planning order with a scripted OpenTofu, not a gateway's admission refusal.Rust integration tests: 35 to 31. Net −471 lines.
Validation
cargo cion darwin_arm64: all steps passed. Lifecycle ran 96 tests, down from 100 onv1.deployment,export_observations,fabric_deployment, andmulti_agentpass against a bundle built from this branch.