Repository navigation
add the 'HiGHS' solver for linear programs - #295386
Merged
Merged
Conversation
silky
force-pushed
the
noon/add-highs
branch
2 times, most recently
from
March 12, 2024 18:56
3c407ba to
b644710
Compare
ConnorBaker
approved these changes
Mar 12, 2024
ConnorBaker
left a comment
Contributor
There was a problem hiding this comment.
Nicely done!
Result of nixpkgs-review pr 295386 run on x86_64-linux 1
1 package built:
- highs
A few suggestions, things to introduce you to, or make you aware of in case you weren't:
- Consider moving away from use of the
reckeyword --stdenv.mkDerivationaccepts either an attribute set, a function to an attribute set (i.e.finalAttrs: {}) or a binary function to an attribute set (i.e.finalAttrs: prevAttrs: {}). This functionality was added specifically for this reason: #119942. More on that discussion here: https://discourse.nixos.org/t/avoid-rec-expresions-in-nixpkgs/8293. In your case, I'd recommend using(finalAttrs: { ... })instead ofrec, and replacingrev = "v${version}";withrev = "v${finalAttrs.version}";. - Consider setting
strictDeps = true;to enforce better separation of build-time and run-time dependencies (not enforced by default). It can help reduce runtime closures and is generally a blessing when doing cross-compilation of packages. It's not super important here, but a cool thing to know about! - Consider quoting
$outininstallCheckPhaseto avoid splitting on whitespace if someone has a funky NixOS store path. - Consider adding yourself as a maintainer, if you're willing :)
IMHO, none of these are blocking and they're all minor suggestions or things I wanted to introduce you to or make you aware of since this is your first contribution -- let me know if you're ready for merge and I'd be happy to make that happen!
Member
Author
|
Thanks @ConnorBaker ! I've made all the changes you suggested :) Much appreciated! Looking forward to getting this merged :) |
Closed
6 of 13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds the HiGHS solver! :)
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.