kodi: make overrideAttrs and withPackages composable

[nvmd]

Description of changes

This work is an up-to-date version of #209580 which has been stale for a long time already. Last time it was postponed due to an upcoming Kodi release, hopefully, we could merge it this time.
I've been using those changes and supporting them for about 2 years in my Nixos configuration with zero problems.
I've also improved it in a couple of places regarding the ability to override, and consistent handling of existing configuration parameters (opticalSupport, vdpauSupport).

• introduction of finalAttrs pattern
  When using a kodi derivation modified with overrideAttrs and adding extensions to it with withPackages the changes were discarded and the original unmodified kodi derivation was wrapped together with the extensions.
  Fix this by switching kodi to use the mkDerivation with finalAttrs pattern (described in stdenv.mkDerivation: overlay style overridable recursive attributes #119942 and https://nixos.org/manual/nixpkgs/stable/#mkderivation-recursive-attributes).

This will make customizing Kodi for other platforms (e.g. Raspberry Pi, which require custom ffmpeg, libcec and other optimizations) much easier when all of overrideAttrs, override, and withPackages are needed at the same time.

Could be tested with something along these lines: (there is also test flake example in the original PR)

with import <nixpkgs> { system = "aarch64-linux"; };

let
  kodi-rpi = ((kodi.overrideAttrs (old: {
    pname = "kodi-rpi";

    ffmpeg = pkgs.ffmpeg_4 {
      withDav1 = true;
      withVaapi = false;
      withVdpau = false;
    };
  })).override {
    libcec = libcec.override {
      withLibraspberrypi = true;
    };
    vdpauSupport = false;
    dav1dSupport = true;
    gbmSupport = true;
  });
in kodi-rpi.withPackages (pkgs: with pkgs; [
    inputstream-adaptive
    inputstream-ffmpegdirect
    inputstream-rtmp
    joystick
    libretro
    libretro-2048
    libretro-fuse
    libretro-genplus
    libretro-mgba
    libretro-nestopia
    libretro-snes9x
    pvr-iptvsimple
    vfs-libarchive
    vfs-rar
])

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[nvmd]

Updated for Kodi 21.0 (#303497)

[aanderse]

@SuperSandro2000 - any chance you can take a look at this as well? ❤️

[nvmd]

Even though this has nothing to do with this PR, it now rather unfortunately weakly depends on #304845, because apache-commons-text suddenly is no longer at the source url and ofborg's compilation checks fail.

[SuperSandro2000]

looks alright to me

[aanderse]

thanks everyone!