Skip to content

kodi: replace source urls for apache dependencies with stable ones - #304845

Merged
SuperSandro2000 merged 1 commit into
NixOS:masterfrom
nvmd:master+kodi-fix-apache-commons
Apr 18, 2024
Merged

kodi: replace source urls for apache dependencies with stable ones#304845
SuperSandro2000 merged 1 commit into
NixOS:masterfrom
nvmd:master+kodi-fix-apache-commons

Conversation

@nvmd

@nvmd nvmd commented Apr 17, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Description of changes

Replaced source of apache groovy, commons-lang3, and commons-text with stable ones, they contain only the latest version:

The most recent source and binary releases for the Apache Commons project are available from this directory listing. For older releases, please use the archives.

commons-text is already not there: https://dlcdn.apache.org/commons/text/binaries/commons-text-1.11.0-bin.zip returns 404, breaking the build of Kodi 20.1 just merged in #303497.

See in a build attempt of #304097: https://logs.ofborg.org/?key=nixos/nixpkgs.304097&attempt_id=45c6a77c-3113-46e8-a971-e5bd1f514559

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nvmd nvmd mentioned this pull request Apr 17, 2024
Merged
6 of 13 tasks
aanderse
aanderse approved these changes Apr 17, 2024
View reviewed changes

@aanderse aanderse left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😓

thank you

@ofborg ofborg Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 17, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 17, 2024
SuperSandro2000
SuperSandro2000 reviewed Apr 17, 2024
View reviewed changes
Comment thread pkgs/applications/video/kodi/unwrapped.nix Outdated
Comment thread pkgs/applications/video/kodi/unwrapped.nix Outdated
@nvmd
nvmd force-pushed the master+kodi-fix-apache-commons branch from f5ed9b6 to d88c3ac Compare April 18, 2024 06:55
@github-actions github-actions Bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Apr 18, 2024
@nvmd
nvmd force-pushed the master+kodi-fix-apache-commons branch from d88c3ac to 67d4f93 Compare April 18, 2024 06:57
@github-actions github-actions Bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog This PR adds or changes release notes 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: vscode A free and versatile code editor that supports almost every major programming language. labels Apr 18, 2024
@nvmd @SuperSandro2000
kodi: use stable mirror:// source urls for apache deps
861d189 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@nvmd
nvmd force-pushed the master+kodi-fix-apache-commons branch from 67d4f93 to 861d189 Compare April 18, 2024 06:59
@github-actions github-actions Bot removed 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog This PR adds or changes release notes 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: vscode A free and versatile code editor that supports almost every major programming language. labels Apr 18, 2024
@nvmd nvmd changed the title kodi: replace sources of apache-commons with stable ones kodi: replace source urls for apache dependencies with stable ones Apr 18, 2024
@nvmd
nvmd removed the request for review from RaitoBezarius April 18, 2024 07:07
@SuperSandro2000
SuperSandro2000 merged commit c18e038 into NixOS:master Apr 18, 2024
@nvmd
nvmd deleted the master+kodi-fix-apache-commons branch April 18, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes
@aanderse aanderse aanderse approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nvmd @SuperSandro2000 @aanderse @wegank