Skip to content

Add WPWE0-7 summary test cases - #1602

Merged
bska merged 1 commit into
OPM:masterfrom
GitPaean:wpwe-summary-tests
Sep 17, 2026
Merged

bska merged 1 commit into
OPM:masterfrom
GitPaean:wpwe-summary-tests

Conversation

@GitPaean

@GitPaean GitPaean commented Sep 11, 2026

Copy link
Copy Markdown
Member

Adds twelve self-contained decks under wpwe/ to exercise the WPWE0-7
support introduced by opm-common#5352
and opm-simulators#7395.
This is a cases-first review: the event semantics can be agreed before reference
output and regression-suite registration are added.

Test decks

  • WPWE-ACTIONX-TYPE-CONVERSION.DATA — converts a producer to an injector and back through ACTIONX, exercising WPWE6 and WPWE5.
  • WPWE-COMPLUMP-CONNECTION-COUNT.DATA — shows that WPWE2 counts connections while the WPWE3 closed-to-bottom test operates on completions.
  • WPWE-CON-PLUSCON.DATA — compares independent CON and +CON closures on one well and shows that both offending connections count towards WPWE2.
  • WPWE-DECK-CONNECTION-CHANGES.DATA — exercises deck-driven connection closure and reopening, including suppression of WPWE1 while a well is stopped.
  • WPWE-DECK-STATUS-CONVERSION.DATA — contrasts silent deck-driven SHUT/STOP changes with producer/injector conversions reported by WPWE6/WPWE5.
  • WPWE-DECK-WELL-ADDITION.DATA — adds wells through WELSPECS during the run and verifies that schedule insertion is not a WPWE0 drilling event.
  • WPWE-MIXED-CLOSURE-CAUSES.DATA — shows that WPWE3 depends on the remaining completion geometry rather than on what closed the other connections.
  • WPWE-PLUSCON-CLOSURE-COUNT.DATA — verifies that the connection violating a +CON limit counts towards WPWE2.
  • WPWE-TIMESTEP-PLACEMENT.DATA — distinguishes per-accepted-timestep event reporting from accumulation over a report interval.
  • WPWE-UDQ-ACTIONX-NO-SUMMARY.DATA — uses WPWE2 from UDQ and ACTIONX without requesting a WPWE vector in SUMMARY.
  • WPWE-WORKOVER-SHUT-STOP.DATA — distinguishes WPWE4 for a workover-stopped well from WPWE7 when no connection remains able to flow.
  • WPWE-WTEST-REOPEN.DATA — verifies that an automatic WTEST reopen reports the number of reopened connections through WPWE1.

The economic-limit cases cross water-cut limits as the wells water out, which
spreads the events across each run. Exact event times can move with the timestep
sequence. Each deck's header states the question it asks, the wells and vectors
that answer it, and the measured behaviour.

The cases reuse the CECON-02 reservoir and initial wells. The grid and property
includes are copied into wpwe/include/ rather than referenced across
directories, so the cases can be handed over and run on their own.

Validation

The documented values were measured with flow_blackoil builds containing the
linked source changes. Serial and two-rank MPI runs produced the same sequence
of nonzero WPWE rows for every case.

Not included yet

  • reference output
  • registration in regressionTests.cmake

Those will follow after the cases and event semantics have been reviewed.

@GitPaean
GitPaean force-pushed the wpwe-summary-tests branch 6 times, most recently from 37d458c to bb4e892 Compare September 14, 2026 13:01
@GitPaean
GitPaean force-pushed the wpwe-summary-tests branch 8 times, most recently from 66c3fbd to 26d4f35 Compare September 17, 2026 13:41
@GitPaean
GitPaean marked this pull request as ready for review September 17, 2026 14:00
@GitPaean
GitPaean requested a balanced review from Copilot September 17, 2026 14:02

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The maintenance reference contains inaccurate timing and run-margin statements and overstates coverage of unrequested UDQ registration.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Adds twelve self-contained WPWE0-7 simulation decks for reviewing event semantics before regression registration.

Changes:

  • Covers connection, workover, conversion, ACTIONX, UDQ, and WTEST scenarios.
  • Adds shared CECON-02-derived model data and summary configuration.
  • Documents expected event sequences and maintenance guidance.
File summaries
File Description
wpwe/WPWE.md Documents expected behavior and execution guidance.
wpwe/WPWE-ACTIONX-TYPE-CONVERSION.DATA Tests ACTIONX well-type conversions.
wpwe/WPWE-COMPLUMP-CONNECTION-COUNT.DATA Tests connection versus completion counting.
wpwe/WPWE-CON-PLUSCON.DATA Compares CON and +CON closures.
wpwe/WPWE-DECK-CONNECTION-CHANGES.DATA Tests deck-driven connection changes.
wpwe/WPWE-DECK-STATUS-CONVERSION.DATA Tests status changes and type conversions.
wpwe/WPWE-DECK-WELL-ADDITION.DATA Tests schedule-time well additions.
wpwe/WPWE-MIXED-CLOSURE-CAUSES.DATA Tests mixed connection-closure causes.
wpwe/WPWE-PLUSCON-CLOSURE-COUNT.DATA Tests +CON closure accounting.
wpwe/WPWE-TIMESTEP-PLACEMENT.DATA Tests timestep-local event placement.
wpwe/WPWE-UDQ-ACTIONX.DATA Exercises WPWE through UDQ and ACTIONX.
wpwe/WPWE-WORKOVER-SHUT-STOP.DATA Distinguishes workover STOP and SHUT events.
wpwe/WPWE-WTEST-REOPEN.DATA Tests automatic WTEST reopening.
wpwe/include/actnum_20x30x10.grdecl Supplies the copied active-cell mask.
wpwe/include/norne_pvt.inc Supplies shared PVT properties.
wpwe/include/permx_model5.grdecl Supplies copied permeability data.
wpwe/include/relperm.inc Supplies relative-permeability tables.
wpwe/include/rock.inc Supplies rock properties.
wpwe/include/test1_20x30x10.grdecl Supplies copied grid geometry.
wpwe/include/wpwe-model.inc Defines the shared reservoir model.
wpwe/include/wpwe-summary.inc Requests WPWE and diagnostic vectors.
wpwe/include/wpwe-wells.inc Defines shared initial wells and controls.
Review details
  • Files reviewed: 20/22 changed files
  • Comments generated: 3
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread wpwe/WPWE.md Outdated
Comment thread wpwe/WPWE.md Outdated
Comment thread wpwe/WPWE.md Outdated
@GitPaean
GitPaean marked this pull request as draft September 17, 2026 14:11
@GitPaean
GitPaean requested a balanced review from Copilot September 17, 2026 15:26

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The numerical event sequences depend on specialized companion builds that cannot be independently validated in this review environment.

Review details
  • Files reviewed: 20/22 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

@GitPaean

Copy link
Copy Markdown
Member Author

jenkins build this please

@GitPaean
GitPaean marked this pull request as ready for review September 17, 2026 19:10
@GitPaean

Copy link
Copy Markdown
Member Author

These are testing cases used to develop WPWE[0-7] event summary. Will pick some of them for regression tests. I am marking them as ready for review now.

@GitPaean
GitPaean requested a review from bska September 17, 2026 19:11
@GitPaean

Copy link
Copy Markdown
Member Author

The WPWE.md was generated during the case testing, adapted to the designed behavoir. At the same time, it might also increase the future maintenance purpose. Feel free to suggest to remove it.

Add twelve self-contained decks that exercise the WPWE0-7 event
indicators. Reuse the CECON-02 reservoir and copy its grid and property
data so the directory can be reviewed and run on its own.

Each deck header states the question it asks and the measured Flow
behaviour: deck-driven events, connection-versus-completion semantics,
per-timestep indicator lifetime, automatic WTEST reopening, and use from
UDQ and ACTIONX.

Leave reference output and regression-suite registration for a follow-up
after the event semantics have been reviewed.
@GitPaean

GitPaean commented Sep 17, 2026

Copy link
Copy Markdown
Member Author

After some thinking, I removed the WPWE.md file. It might not be used and it might be difficult to keep consistent.

@bska bska left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for the effort in covering a multitude of cases. This looks good to me and I'll merge into master.

@bska
bska merged commit 624be0e into OPM:master Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants