Add WPWE0-7 summary test cases - #1602
Conversation
37d458c to
bb4e892
Compare
66c3fbd to
26d4f35
Compare
b3ab245 to
036facf
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The maintenance reference contains inaccurate timing and run-margin statements and overstates coverage of unrequested UDQ registration.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds twelve self-contained WPWE0-7 simulation decks for reviewing event semantics before regression registration.
Changes:
- Covers connection, workover, conversion, ACTIONX, UDQ, and WTEST scenarios.
- Adds shared CECON-02-derived model data and summary configuration.
- Documents expected event sequences and maintenance guidance.
File summaries
| File | Description |
|---|---|
wpwe/WPWE.md |
Documents expected behavior and execution guidance. |
wpwe/WPWE-ACTIONX-TYPE-CONVERSION.DATA |
Tests ACTIONX well-type conversions. |
wpwe/WPWE-COMPLUMP-CONNECTION-COUNT.DATA |
Tests connection versus completion counting. |
wpwe/WPWE-CON-PLUSCON.DATA |
Compares CON and +CON closures. |
wpwe/WPWE-DECK-CONNECTION-CHANGES.DATA |
Tests deck-driven connection changes. |
wpwe/WPWE-DECK-STATUS-CONVERSION.DATA |
Tests status changes and type conversions. |
wpwe/WPWE-DECK-WELL-ADDITION.DATA |
Tests schedule-time well additions. |
wpwe/WPWE-MIXED-CLOSURE-CAUSES.DATA |
Tests mixed connection-closure causes. |
wpwe/WPWE-PLUSCON-CLOSURE-COUNT.DATA |
Tests +CON closure accounting. |
wpwe/WPWE-TIMESTEP-PLACEMENT.DATA |
Tests timestep-local event placement. |
wpwe/WPWE-UDQ-ACTIONX.DATA |
Exercises WPWE through UDQ and ACTIONX. |
wpwe/WPWE-WORKOVER-SHUT-STOP.DATA |
Distinguishes workover STOP and SHUT events. |
wpwe/WPWE-WTEST-REOPEN.DATA |
Tests automatic WTEST reopening. |
wpwe/include/actnum_20x30x10.grdecl |
Supplies the copied active-cell mask. |
wpwe/include/norne_pvt.inc |
Supplies shared PVT properties. |
wpwe/include/permx_model5.grdecl |
Supplies copied permeability data. |
wpwe/include/relperm.inc |
Supplies relative-permeability tables. |
wpwe/include/rock.inc |
Supplies rock properties. |
wpwe/include/test1_20x30x10.grdecl |
Supplies copied grid geometry. |
wpwe/include/wpwe-model.inc |
Defines the shared reservoir model. |
wpwe/include/wpwe-summary.inc |
Requests WPWE and diagnostic vectors. |
wpwe/include/wpwe-wells.inc |
Defines shared initial wells and controls. |
Review details
- Files reviewed: 20/22 changed files
- Comments generated: 3
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
036facf to
80df76b
Compare
There was a problem hiding this comment.
🔵 Needs a closer look
The numerical event sequences depend on specialized companion builds that cannot be independently validated in this review environment.
Review details
- Files reviewed: 20/22 changed files
- Comments generated: 0 new
- Review effort level: Balanced
|
jenkins build this please |
|
These are testing cases used to develop WPWE[0-7] event summary. Will pick some of them for regression tests. I am marking them as ready for review now. |
|
The |
80df76b to
55ceb40
Compare
Add twelve self-contained decks that exercise the WPWE0-7 event indicators. Reuse the CECON-02 reservoir and copy its grid and property data so the directory can be reviewed and run on its own. Each deck header states the question it asks and the measured Flow behaviour: deck-driven events, connection-versus-completion semantics, per-timestep indicator lifetime, automatic WTEST reopening, and use from UDQ and ACTIONX. Leave reference output and regression-suite registration for a follow-up after the event semantics have been reviewed.
|
After some thinking, I removed the WPWE.md file. It might not be used and it might be difficult to keep consistent. |
bska
left a comment
There was a problem hiding this comment.
Thank you so much for the effort in covering a multitude of cases. This looks good to me and I'll merge into master.
Adds twelve self-contained decks under
wpwe/to exercise the WPWE0-7support introduced by opm-common#5352
and opm-simulators#7395.
This is a cases-first review: the event semantics can be agreed before reference
output and regression-suite registration are added.
Test decks
WPWE-ACTIONX-TYPE-CONVERSION.DATA— converts a producer to an injector and back through ACTIONX, exercising WPWE6 and WPWE5.WPWE-COMPLUMP-CONNECTION-COUNT.DATA— shows that WPWE2 counts connections while the WPWE3 closed-to-bottom test operates on completions.WPWE-CON-PLUSCON.DATA— compares independentCONand+CONclosures on one well and shows that both offending connections count towards WPWE2.WPWE-DECK-CONNECTION-CHANGES.DATA— exercises deck-driven connection closure and reopening, including suppression of WPWE1 while a well is stopped.WPWE-DECK-STATUS-CONVERSION.DATA— contrasts silent deck-driven SHUT/STOP changes with producer/injector conversions reported by WPWE6/WPWE5.WPWE-DECK-WELL-ADDITION.DATA— adds wells throughWELSPECSduring the run and verifies that schedule insertion is not a WPWE0 drilling event.WPWE-MIXED-CLOSURE-CAUSES.DATA— shows that WPWE3 depends on the remaining completion geometry rather than on what closed the other connections.WPWE-PLUSCON-CLOSURE-COUNT.DATA— verifies that the connection violating a+CONlimit counts towards WPWE2.WPWE-TIMESTEP-PLACEMENT.DATA— distinguishes per-accepted-timestep event reporting from accumulation over a report interval.WPWE-UDQ-ACTIONX-NO-SUMMARY.DATA— uses WPWE2 from UDQ and ACTIONX without requesting a WPWE vector inSUMMARY.WPWE-WORKOVER-SHUT-STOP.DATA— distinguishes WPWE4 for a workover-stopped well from WPWE7 when no connection remains able to flow.WPWE-WTEST-REOPEN.DATA— verifies that an automaticWTESTreopen reports the number of reopened connections through WPWE1.The economic-limit cases cross water-cut limits as the wells water out, which
spreads the events across each run. Exact event times can move with the timestep
sequence. Each deck's header states the question it asks, the wells and vectors
that answer it, and the measured behaviour.
The cases reuse the CECON-02 reservoir and initial wells. The grid and property
includes are copied into
wpwe/include/rather than referenced acrossdirectories, so the cases can be handed over and run on their own.
Validation
The documented values were measured with
flow_blackoilbuilds containing thelinked source changes. Serial and two-rank MPI runs produced the same sequence
of nonzero WPWE rows for every case.
Not included yet
regressionTests.cmakeThose will follow after the cases and event semantics have been reviewed.