Repository navigation
ci: pin GitHub Actions to commit SHAs - #1314
chopmob-cloud wants to merge 1 commit into
Conversation
🧪 Code Coverage (vs
|
ade341e to
fbd96fd
Compare
Rebased onto current
|
| action | pinned SHA resolves to |
|---|---|
actions/checkout@v7.0.1 |
3d3c42e5aac5ba805825da76410c181273ba90b1 |
astral-sh/setup-uv@v7.6.0 |
37802adc94f370d6bfd71619e3f0bf239e1f3b78 |
actions/cache@v6.1.0 |
55cc8345863c7cc4c66a329aec7e433d2d1c52a9 |
Checks, per this repo's docs/ai/mandatory_checks.md
uv run ruff check→ All checks passed.uv run pytest→ 2482 passed, 203 skipped, 4 xfailed (--ignore=tests/integration/cross_version).uv run ty check→ 3 diagnostics, identical on pristinemain(verified by checking outupstream/mainand re-running), so pre-existing and unrelated.- The 4
push_notificationserrors and thecross_versionfailures also reproduce on pristinemain— they are Windows subprocess/shell environment issues (TypeError: stat: path should be ... not NoneType,shell not found: neither %ComSpec% nor %SystemRoot% is set), not branch regressions. CI runs these on Linux.
All 17 checks now pass, so this is ready for review. Head is fbd96fd9204d8523199caa0000a49120604eaf41.
Pin the GitHub Actions in .github/workflows to full-length commit SHAs with version comments. A mutable tag can be re-pointed after review, so pinning to a commit SHA is the OpenSSF Scorecard Pinned-Dependencies control. Ref-pinning only, same versions, no functional change. Generated with pinact; each SHA verified to resolve to its version tag. Signed-off-by: AlgoVoi <chopmob@gmail.com>
fbd96fd to
6959944
Compare
|
Rebased onto current What conflicted. What I did instead. Those two files still carried unpinned action refs on Verification. Every One thing worth your call. Two upstream tags have moved since the original pins in this PR: |
|
Correction to my earlier comment on this PR — I need to withdraw the "two tags have moved" remark. It was wrong. I had compared the pins against the moving major tags (
So those two pins are accurate, not stale. Apologies for the noise. While auditing, I did find three refs that are behind their major tag, but all three are pre-existing on
There is also a pre-existing mislabel worth fixing separately: several workflows pin |
Pins the GitHub Actions in
.github/workflowsto full-length commit SHAs with# vXversion comments, bringing this repo in line with the sibling repo a2a-go, which is already fully pinned.Why
A mutable tag like
@v7can be moved to new code after review, so a compromised or hijacked action tag would run with this workflow's permissions. Pinning to a commit SHA is the OpenSSF Scorecard "Pinned-Dependencies" control and the GitHub-recommended practice. This repo already runs Dependabot for thegithub-actionsecosystem, so Dependabot keeps the SHA pins current (it bumps the SHA and the# vXcomment together).What
uses:across 10 workflow files to its exact commit SHA, keeping a# vXversion comment. Same versions, no upgrades or downgrades.pinact; each pinned SHA was verified to resolve to the version in its comment via the GitHub API.# vXcomment expanded to the exact version (same SHA).