Repository navigation
Conversation
…binaries Every job that runs buf starts with a cold module cache and pulls the buf.lock deps from buf.build, which sometimes rejects anonymous requests from shared runner IPs with 403. On top of that, buf and golangci-lint were compiled with go install in every job. - cache the buf module cache, keyed on buf.lock, in the proto lint, breakage and coverage jobs - install buf and golangci-lint from their release binaries, checked against the sha256 list each release publishes
Contributor
|
Warning Review limit reached
This review includes 4 billable files and costs up to $1.00.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 59 minutes for your next included review. View limit detailsLimit details: You’ve used the included review currently available. Your 77 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Review configuration: ⚙️ Run configurationConfiguration used: Repository: akash-network/chain-sdk/.coderabbit.yaml Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (4)
Comment |
3 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Caches buf modules in the jobs that run buf, and installs buf and golangci-lint from checksum-verified release binaries instead of compiling them in every job. Split out of #363, which now only moves the jobs to GitHub-hosted runners.
🔧 Purpose of the Change
📌 Related Issues
✅ Checklist
📎 Notes for Reviewers
make/setup-cache.mkchange also applies locally: both tools now download instead of compiling, and a checksum mismatch fails the install.