Skip to content

ci: cache buf modules and install buf and golangci-lint from release binaries #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
baktun14 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci: cache buf modules and install buf and golangci-lint from release binaries #364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/breakage.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,11 @@ jobs:
go-version: "${{ env.GOVERSION }}"
- name: go mod vendor
run: make modvendor
- name: Cache buf modules
uses: actions/cache@v4
with:
path: ~/.cache/buf
key: buf-${{ runner.os }}-${{ hashFiles('buf.lock') }}
restore-keys: buf-${{ runner.os }}-
- name: check-breakage
run: make proto-check-breaking
6 changes: 6 additions & 0 deletions .github/workflows/lint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,12 @@ jobs:
go-version: "${{ env.GOVERSION }}"
- name: go mod vendor
run: make modvendor
- name: Cache buf modules
uses: actions/cache@v4
with:
path: ~/.cache/buf
key: buf-${{ runner.os }}-${{ hashFiles('buf.lock') }}
restore-keys: buf-${{ runner.os }}-
- name: lint-proto
run: make lint-proto
sdl-schema:
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,12 @@ jobs:
node-version: "${{ env.NODE_VERSION }}"
cache: npm
cache-dependency-path: ts/package-lock.json
- name: Cache buf modules
uses: actions/cache@v4
with:
path: ~/.cache/buf
key: buf-${{ runner.os }}-${{ hashFiles('buf.lock') }}
restore-keys: buf-${{ runner.os }}-
- uses: actions/setup-go@v5
with:
go-version: "${{ env.GOVERSION }}"
Expand Down
36 changes: 32 additions & 4 deletions make/setup-cache.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,29 @@ ifeq ($(UNAME_OS),Darwin)
PROTOC_ZIP ?= protoc-${PROTOC_VERSION}-osx-universal_binary.zip
endif

SHA256SUM := $(shell command -v sha256sum 2>/dev/null || echo "shasum -a 256")

# verify_sha256 checks a downloaded file against the release's published checksum list
# $(1): checksum list URL, $(2): asset name as listed there, $(3): downloaded file
define verify_sha256
expected=$$(curl -fsSL "$(1)" | awk '$$2 == "$(2)" { print $$1 }'); \
actual=$$($(SHA256SUM) "$(3)" | awk '{ print $$1 }'); \
if [ -z "$$expected" ] || [ "$$expected" != "$$actual" ]; then \
echo "checksum mismatch for $(2): expected '$$expected', got '$$actual'"; \
rm -f "$(3)"; \
exit 1; \
fi
endef

BUF_RELEASE_URL := https://github.com/bufbuild/buf/releases/download/v$(BUF_VERSION)
BUF_ASSET := buf-$(UNAME_OS)-$(UNAME_ARCH)

GOLANGCI_LINT_OS := $(shell echo $(UNAME_OS) | tr '[:upper:]' '[:lower:]')

@troian troian Oct 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is UNAME_ARCH

GOLANGCI_LINT_ARCH := $(patsubst aarch64,arm64,$(patsubst x86_64,amd64,$(UNAME_ARCH)))
GOLANGCI_LINT_RELEASE_URL := https://github.com/golangci/golangci-lint/releases/download/$(GOLANGCI_LINT_VERSION)
GOLANGCI_LINT_ASSET := golangci-lint-$(patsubst v%,%,$(GOLANGCI_LINT_VERSION))-$(GOLANGCI_LINT_OS)-$(GOLANGCI_LINT_ARCH)
GOLANGCI_LINT_CHECKSUMS := golangci-lint-$(patsubst v%,%,$(GOLANGCI_LINT_VERSION))-checksums.txt

$(AKASH_DEVCACHE):
@echo "creating .cache dir structure..."
mkdir -p $@
Expand All @@ -26,7 +49,10 @@ cache: $(AKASH_DEVCACHE)
$(BUF_VERSION_FILE): $(AKASH_DEVCACHE)
@echo "installing buf v$(BUF_VERSION) ..."
rm -f $(BUF)
(cd $(GO_ROOT); GOBIN=$(AKASH_DEVCACHE_BIN) $(GO) install github.com/bufbuild/buf/cmd/buf@v$(BUF_VERSION))
curl -fsSL -o $(BUF).download "$(BUF_RELEASE_URL)/$(BUF_ASSET)"
$(call verify_sha256,$(BUF_RELEASE_URL)/sha256.txt,$(BUF_ASSET),$(BUF).download)
chmod +x $(BUF).download
mv $(BUF).download $(BUF)
rm -rf "$(dir $@)"
mkdir -p "$(dir $@)"
touch $@
Expand Down Expand Up @@ -152,11 +178,13 @@ $(MOCKERY_VERSION_FILE): $(AKASH_DEVCACHE)
touch $@
$(MOCKERY): $(MOCKERY_VERSION_FILE)

$(GOLANGCI_LINT_VERSION_FILE): $(SEMVER) $(AKASH_DEVCACHE)
$(GOLANGCI_LINT_VERSION_FILE): $(AKASH_DEVCACHE)
@echo "installing golangci-lint $(GOLANGCI_LINT_VERSION) ..."
rm -f $(GOLANGCI_LINT)
$(eval GOLANGCI_LINT_MAJOR := $(shell $(SEMVER) get major $(GOLANGCI_LINT_VERSION)))
(cd $(GO_ROOT); GOBIN=$(AKASH_DEVCACHE_BIN) go install github.com/golangci/golangci-lint/v$(GOLANGCI_LINT_MAJOR)/cmd/golangci-lint@$(GOLANGCI_LINT_VERSION))
curl -fsSL -o $(GOLANGCI_LINT).tar.gz "$(GOLANGCI_LINT_RELEASE_URL)/$(GOLANGCI_LINT_ASSET).tar.gz"
$(call verify_sha256,$(GOLANGCI_LINT_RELEASE_URL)/$(GOLANGCI_LINT_CHECKSUMS),$(GOLANGCI_LINT_ASSET).tar.gz,$(GOLANGCI_LINT).tar.gz)

@troian troian Oct 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

download tar into cache dir

tar -xzf $(GOLANGCI_LINT).tar.gz -C $(AKASH_DEVCACHE_BIN) --strip-components=1 $(GOLANGCI_LINT_ASSET)/golangci-lint
rm -f $(GOLANGCI_LINT).tar.gz
rm -rf "$(dir $@)"
mkdir -p "$(dir $@)"
touch $@
Expand Down
Loading