Repository navigation
examples/optee_gp: Include stdlib.h and string.h. - #3845
Merged
Merged
Conversation
cederom
reviewed
Oct 14, 2026
optee_gp_main.c calls malloc(), free(), memset() and memcmp(), but got their declarations only indirectly. nuttx/lib/lib.h is no longer included by stdio.h, so imx93-evk:optee does not compile. Include the headers directly. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Marco Casaroli <marco.casaroli@gmail.com>
casaroli
force-pushed
the
optee-gp-stdlib
branch
from
October 14, 2026 12:39
7aa1716 to
a088cd2
Compare
cederom
approved these changes
Oct 14, 2026
This was referenced Oct 14, 2026
Merged
xiaoxiang781216
approved these changes
Oct 14, 2026
🔗 Cross-repo PR dependenciesThe read-only Build run reported the following dependent PR(s) and fetched head SHA(s): CI run: https://github.com/apache/nuttx-apps/actions/runs/38565544036 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends-on: apache/nuttx/pull/20661
Summary
imx93-evk:opteedoes not compile on master:optee_gp_main.c:115: error: implicit declaration of function 'malloc'.optee_gp_main.ccallsmalloc(),free(),memset()andmemcmp(), but got their declarations only indirectly. Since apache/nuttx#20565,stdio.hdoes not includenuttx/lib/lib.h. This PR includesstdlib.handstring.hdirectly.Impact
Build fix only. This config fails the
Linux (arm64-01)CI job of every nuttx PR.Testing
imx93-evk:opteebuilds on master with this PR.tools/checkpatch.sh -fpasses.