Repository navigation
mcpc: link only mcpc, drop libsecret, fix strict audit - #59
Merged
Merged
Conversation
- Use formula_opt_bin("node") instead of Formula["node"].opt_bin
(brew audit --strict).
- Symlink only bin/mcpc into the prefix. mcpc starts its bridge as
`node dist/bridge/index.js` and never runs mcpc-bridge by name, and the
executable is being removed upstream (apify/mcpc#435). The shebang
rewrite still globs the package's bin/ so it keeps working once
mcpc-bridge is gone.
- Drop the Linux libsecret dependency: the prebuilt @napi-rs/keyring addon
talks to D-Bus directly and does not link libsecret.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017YGopmusCEniC5NmoxTyAA
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The absence of mcpc-bridge should be protected by an automated formula-test assertion.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Updates the mcpc formula to match upstream bridge packaging and satisfy strict Homebrew audits.
Changes:
- Exposes only the
mcpcexecutable. - Removes the unnecessary Linux
libsecretdependency. - Uses Homebrew’s audited Node path helper.
| File | Description |
|---|---|
Formula/mcpc.rb |
Updates dependencies, executable linking, and Node test invocation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| bin.install_symlink libexec.glob("bin/*") | ||
| # Only mcpc goes on PATH: it starts its bridge as `node dist/bridge/index.js` | ||
| # and never runs mcpc-bridge by name. | ||
| bin.install_symlink libexec/"bin/mcpc" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs apify/mcpc#435
formula_opt_bin("node")to fixbrew audit --strict.mcpcintobin. mcpc starts its bridge withnode dist/bridge/index.js, never asmcpc-bridge. The shebang rewrite still covers every file in the package'sbin/, so it works oncemcpc-bridgeis removed.libsecreton Linux. The prebuilt keyring addon talks to D-Bus directly and doesn't link libsecret.The update workflow only rewrites
url/sha256, so it won't undo these changes.Checks run on Linux:
brew style,brew install --build-from-source,brew testandbrew audit --strictall passed, andmcpc-bridgeisn't in$(brew --prefix)/bin. Not run on macOS.🤖 Generated with Claude Code
https://claude.ai/code/session_017YGopmusCEniC5NmoxTyAA