Skip to content

mcpc: link only mcpc, drop libsecret, fix strict audit #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jancurn merged 1 commit into from
Oct 3, 2026
Merged

mcpc: link only mcpc, drop libsecret, fix strict audit #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions Formula/mcpc.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,20 +11,16 @@ class Mcpc < Formula

depends_on "node"

on_linux do
# @napi-rs/keyring reaches the OS keychain through the Secret Service API.
# Without libsecret, mcpc falls back to ~/.mcpc/credentials.json (mode 0600).
depends_on "libsecret"
end

def install
system "npm", "install", *std_npm_args
# Both executables ship "#!/usr/bin/env node", so a node earlier in PATH
# The package's executables ship "#!/usr/bin/env node", so a node earlier in PATH
# (nvm, asdf, system) would run mcpc against node_modules installed for
# Homebrew's node — and possibly under a runtime older than the required
# >= 22.12. Point them at Homebrew's node instead.
rewrite_shebang detected_node_shebang, *libexec.glob("lib/node_modules/@apify/mcpc/bin/*")
bin.install_symlink libexec.glob("bin/*")
# Only mcpc goes on PATH: it starts its bridge as `node dist/bridge/index.js`
# and never runs mcpc-bridge by name.
bin.install_symlink libexec/"bin/mcpc"
end

test do
Expand All @@ -48,6 +44,6 @@ def install
# revision bump.
keyring = libexec.glob("lib/node_modules/**/@napi-rs/keyring").first
refute_nil keyring, "@napi-rs/keyring is missing from the install"
system Formula["node"].opt_bin/"node", "-e", "require(#{keyring.to_s.inspect})"
system formula_opt_bin("node")/"node", "-e", "require(#{keyring.to_s.inspect})"
end
end
Loading