Fix Timex.Duration.parse!/2 was calling parse/1 instead of parse/2 - #796
Open
bfolkens wants to merge 1 commit into
Open
Fix Timex.Duration.parse!/2 was calling parse/1 instead of parse/2#796bfolkens wants to merge 1 commit into
bfolkens wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fixes #795
Currently, Timex.Duration.parse!/2 calls parse/1 instead of parse/2, so it ignores the
parserargument. This patch just changes the call to parse/2, in order to preserve the altparserfunctionality.Checklist
NOTE:
Timex.Duration.parseisn't currently covered by any of the tests. I'm wondering if that was intentional or I'm missing something, or perhaps they were removed by accident? Happy to write those if needed.