Skip to content

Fix Timex.Duration.parse!/2 was calling parse/1 instead of parse/2 #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bfolkens wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −1
Open

Fix Timex.Duration.parse!/2 was calling parse/1 instead of parse/2 #796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
- Updated tzdata to fix issues with 2024b
- Fix deprecation: Module.eval_quoted/4 is deprecated. Use Code.eval_quoted/3 instead
- Fix deprecation: "min..max inside match is deprecated"
- Fix Duration.parse!/2 no longer ignores `parser` argument

---

Expand Down
2 changes: 1 addition & 1 deletion lib/parse/duration/parser.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ defmodule Timex.Parse.Duration.Parser do
"""
@spec parse!(String.t(), module()) :: Duration.t() | no_return
def parse!(str, parser) when is_binary(str) and is_atom(parser) do
case parse(str) do
case parse(str, parser) do
{:ok, d} -> d
{:error, reason} when is_binary(reason) -> raise ParseError, message: reason
{:error, term} -> raise ParseError, message: "#{inspect(term)}"
Expand Down