Repository navigation
settings-migrations: add ecs instance-ip-compatibility setting - #4985
Draft
jackvreeken wants to merge 1 commit into
Draft
jackvreeken wants to merge 1 commit into
jackvreeken wants to merge 1 commit into
Conversation
….68.0 Add settings.ecs.instance-ip-compatibility when upgrading from 1.67.0 to 1.68.0. The standard migration removes it on downgrade. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Jack Vreeken <jack@vreeken.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #4984
Description of changes:
Adds the
AddSettingsMigrationforsettings.ecs.instance-ip-compatibility, so downgrades drop the new key.This waits for settings-sdk and core-kit releases that carry bottlerocket-os/bottlerocket-settings-sdk#161 and bottlerocket-os/bottlerocket-core-kit#1101. I'll then add the pin and
Twoliter.tomlbumps ahead of the migration. 1.68.0 is already in release prep, so I'll also retarget the migration, likely to v1.69.0.Testing done:
cargo build -p ecs-instance-ip-compatibilityandcargo fmt --checkpassTerms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.