Skip to content

settings-migrations: add ecs instance-ip-compatibility setting #4985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jackvreeken wants to merge 1 commit into
base: develop
Choose a base branch
from
+42 −1
Draft

settings-migrations: add ecs instance-ip-compatibility setting #4985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Release.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,4 +486,6 @@ version = "1.68.0"
"migrate_v1.66.0_kubelet-dra-drivers-nvidia-enabled.lz4"
]
"(1.66.0, 1.67.0)" = []
"(1.67.0, 1.68.0)" = []
"(1.67.0, 1.68.0)" = [
"migrate_v1.68.0_ecs-instance-ip-compatibility.lz4"
]
7 changes: 7 additions & 0 deletions sources/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions sources/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ members = [
"settings-migrations/v1.66.0/kubernetes-memory-qos-settings",
"settings-migrations/v1.66.0/nvidia-driver-branch-setting",
"settings-migrations/v1.66.0/kubelet-dra-drivers-nvidia-enabled",
"settings-migrations/v1.68.0/ecs-instance-ip-compatibility",

"settings-plugins/aws-dev",
"settings-plugins/aws-ecs-2",
Expand Down
10 changes: 10 additions & 0 deletions sources/settings-migrations/v1.68.0/ecs-instance-ip-compatibility/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
[package]
name = "ecs-instance-ip-compatibility"
version = "0.1.0"
license = "Apache-2.0 OR MIT"
edition = "2021"
publish = false
exclude = ["README.md"]

[dependencies]
migration-helpers.workspace = true
21 changes: 21 additions & 0 deletions sources/settings-migrations/v1.68.0/ecs-instance-ip-compatibility/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
use migration_helpers::common_migrations::AddSettingsMigration;
use migration_helpers::{migrate, Result};
use std::process;

/// We added a new setting for overriding the IP family the ECS agent registers with:
/// - settings.ecs.instance-ip-compatibility
fn run() -> Result<()> {
migrate(AddSettingsMigration(&[
"settings.ecs.instance-ip-compatibility",
]))
}

// Returning a Result from main makes it print a Debug representation of the error, but with Snafu
// we have nice Display representations of the error, so we wrap "main" (run) and print any error.
// https://github.com/shepmaster/snafu/issues/110
fn main() {
if let Err(e) = run() {
eprintln!("{e}");
process::exit(1);
}
}