Skip to content

Route NCES/NCES2 output through logging instead of print - #656

Merged
Demirrr merged 1 commit into
developfrom
refactor/nces-logging
Oct 23, 2026
Merged

Demirrr merged 1 commit into
developfrom
refactor/nces-logging

Conversation

@Demirrr

@Demirrr Demirrr commented Oct 23, 2026

Copy link
Copy Markdown
Member

Part of the print to logger cleanup in Improvements.md §3 (first of several module-by-module PRs).

  • learners/nces.py and learners/nces2.py (so also ROCES): 27 print calls become logger calls with levels (info for status/verbose predictions, warning for missing/partial pretrained weights and auto-train notices, error for failures). Same convention as drill.py.
  • ANSI colour escapes dropped; fixed the Ćheck typo; leftover debug print(num_workers) in NCES2.train is now logger.debug.
  • Improvements.md counts updated (270 to ~245); CHANGELOG entry added.

Local: tests/test_nces.py, test_nces2.py, test_roces.py pass (3 passed; needed LD_PRELOAD of the system libstdc++ for pysat in my conda env, unrelated to this change); ruff clean.

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant