Repository navigation
fix(deps): Bump @vercel/client and patch picomatch ReDoS - #982
Merged
Merged
Conversation
Bump @vercel/client to ^18.12.3. Its @vercel/build-utils no longer pulls in @vercel/python-analysis, which removes zod 3 from the tree (GHSA-mrhx-c7xc-m3w5). picomatch has no fixed release for GHSA-fc5q-39xc-vjpf. Backport the open upstream fix (micromatch/picomatch#267, #268 for 2.x) as pnpm patches for the installed 4.0.7 and 2.3.2, in root and docs. Also check compiled bracket classes so a range such as [+-0], which includes /, is not collapsed. Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
Contributor
|
BYK
approved these changes
Nov 18, 2026
BYK
enabled auto-merge (squash)
November 18, 2026 11:34
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a25c2a6. Configure here.
BYK
pushed a commit
that referenced
this pull request
Nov 18, 2026
…#983) The local picomatch patches from #982 for [GHSA-fc5q-39xc-vjpf](GHSA-fc5q-39xc-vjpf) keep the repetition of any single-branch extglob with a literal `/`. They assume the slash fixes where each repeat starts. Two shapes break that and still backtrack exponentially: - `+(**/a)`: a globstar crosses `/`. - `+(*/*)`: one repeat's trailing `*` and the next repeat's leading `*` share a path segment, so every segment can split two ways. Now a slash body keeps its repetition only when it has no globstar and every path segment holds at most one `*`, counting the segment shared across repeats. Globs like `+(src/*/)` and `+(src/*/*.js)` match as before. `+(**/a)`, `+(*/*)` and `+(*a/*)` are literalized, like the other risky extglobs. The change covers the 4.0.7 and 2.3.2 patches in root and `docs/`. <!-- junior-request-attribution:start --> via @BYK. <!-- junior-request-attribution:end --> <!-- junior-session-footer:start --> <!-- junior-conversation-id:agent%3Aa3f271eaa645c4e79ce41158088ba41e --> -- [View Session](https://junior-prod.sentry.dev/conversations/agent%3Aa3f271eaa645c4e79ce41158088ba41e) [[Sentry]](https://sentry.sentry.io/explore/conversations/agent%3Aa3f271eaa645c4e79ce41158088ba41e/?project=4510944073809921) <!-- junior-session-footer:end --> Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com>
8 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes the two high advisories in the root and
docs/lockfiles.GHSA-mrhx-c7xc-m3w5 (zod < 4.6.6), root. zod 3 came only from
@vercel/client > @vercel/build-utils@14 > @vercel/python-analysis.@vercel/client@^18.12.3uses@vercel/build-utils@15.4.2, which no longer depends on python-analysis, so zod drops out of the tree. A zod override would force zod 4 onto zod 3 code. ThecreateDeploymentAPI that the vercel target uses has not changed.GHSA-fc5q-39xc-vjpf (picomatch ReDoS), root and docs. There is no fixed release. Following the
bracesprecedent, this adds local pnpm patches for both installed versions, 4.0.7 and 2.3.2. 2.3.2 has the same bug. The advisory links micromatch/picomatch#194, but that PR covers?-leading extglobs and does not fix+(*a). The patches backport micromatch/picomatch#267 (#268 for 2.x):?,*, and bracket classes that cannot match/absorbs its own repetition.+(P)compiles as(P)and*(P)as(P)?, and the matches stay the same.The patch differs from upstream in one place. Upstream would collapse a bracket range like
[+-0], which includes/, and that changes what it matches. The patch checks each compiled bracket class first. Details are inpatches/README.md.After merge: Dependabot matches on version, so it will keep flagging the patched picomatch 4.0.7 and 2.3.2, as it already does for braces. Dismiss those alerts by hand.
Not covered: repeated extglobs with several branches that contain
*, such as+(*a|b). That is the general upstream issue micromatch/picomatch#175. Literalizing them would break globs like+(*.js|*.ts).via @BYK.
--
View Session [Sentry]