[WIP] perf(telemetry): serialize batches on shared thread pool by jpnurmi · Pull Request #1946 · getsentry/sentry-native

jpnurmi · 2026-08-04T08:10:00Z

Warning

WIP 🚧🔨⏳⛔

Let the telemetry module own a shared serialization pool for enabled telemetry batchers.
Use the pool for log and metric batch serialization while keeping completion ordered through the batcher.

before-vs-after.ftrace.zip

Close: #1862

_{Stack created with GitHub Stacks CLI • Give Feedback 💬}

codecov · 2026-08-04T08:42:50Z

Codecov Report

❌ Patch coverage is 86.78571% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.30%. Comparing base (6ca0dce) to head (1134ee2).

Additional details and impacted files

@@                     Coverage Diff                      @@
##           jpnurmi/perf/thread-pool    #1946      +/-   ##
============================================================
+ Coverage                     76.08%   76.30%   +0.21%     
============================================================
  Files                            94       94              
  Lines                         22441    22678     +237     
  Branches                       4017     4051      +34     
============================================================
+ Hits                          17075    17305     +230     
- Misses                         4468     4471       +3     
- Partials                        898      902       +4

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit 9cb4261. Configure here.}

Let the telemetry lifecycle own a shared serialization pool for enabled telemetry batchers. Use the pool for log and metric batch serialization while keeping completion ordered through the batcher flush lifecycle.

Convert the telemetry batcher from the removed sentry__spin_lock helpers to the promoted sentry__spinlock_* API. The ref guard, in-flight task list, and flush reentrancy guard are all spinlocks, so store them as sentry_spinlock_t instead of raw long fields. Use sentry__spinlock_try_lock for the normal flush path. It preserves the existing one-shot behavior when another flush is active while using the same primitive as the crash-safe wait path. Remove the temporary sentry__spin_lock* compatibility aliases now that the batcher is on the shared API.

Keep crash-safe flushes from making a started batcher thread look fully stopped before normal shutdown has a chance to wake and join it. Always run the final flush and task drain so linked serialization tasks cannot outlive the batcher they reference. Add regression coverage for crash-safe flush followed by shutdown while thread-pool work is still pending.

cursor Bot reviewed Aug 4, 2026

View reviewed changes

Comment thread src/sentry_batcher.c

Comment thread src/sentry_batcher.c

jpnurmi force-pushed the jpnurmi/perf/telemetry-pool branch from ae3b36a to 53a8c3e Compare August 4, 2026 11:44

sentry Bot reviewed Aug 4, 2026

View reviewed changes