Skip to content

feat(workflow_engine): Bypass Inbox group frequency suppression - #131093

Open
shashjar wants to merge 11 commits into
shashjar/feat/iswf-3705-group-less-actionsfrom
shashjar/feat/iswf-3705-inbox-frequency
Open

shashjar wants to merge 11 commits into
shashjar/feat/iswf-3705-group-less-actionsfrom
shashjar/feat/iswf-3705-inbox-frequency

Conversation

@shashjar

@shashjar shashjar commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

Refs https://linear.app/getsentry/issue/ISWF-3705/support-group-less-action-invocation-and-inbox-frequency-semantics.

Inbox workflows bypass per-group frequency suppression. All non-Inbox workflows, including Seer investigation workflows, retain their existing suppression and are excluded from group-less runs. Actions must pass their handler's event validation before consuming frequency state. Eligibility is calculated per workflow/action association before equivalent actions are deduplicated for dispatch.

Immediate and delayed processing record history only for eligible workflows. This applies to existing non-Inbox workflows immediately, without a new feature flag: a workflow no longer gets a history row merely because it shares an action with an eligible workflow when its own conditions did not pass or it was frequency-suppressed.

https://app.notion.com/p/sentry/Investigation-Events-Workflow-Engine-40c8b10e4b5d80d18c4ed6c802d55d64

@linear-code

linear-code Bot commented Nov 13, 2026

Copy link
Copy Markdown

ISWF-3705

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 13, 2026
@shashjar
shashjar added this pull request to stack #131096 November 13, 2026 18:30
@shashjar
shashjar force-pushed the shashjar/feat/iswf-3705-inbox-frequency branch from 87e8566 to b255042 Compare November 13, 2026 18:39
@shashjar
shashjar force-pushed the shashjar/feat/iswf-3705-inbox-frequency branch 2 times, most recently from 4a78323 to d5fc207 Compare November 19, 2026 23:59
@sentry

sentry Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Sentry Snapshot Testing

Name Added Removed Changed Renamed Unchanged Skipped Status
sentry-frontend
sentry-frontend
0 0 0 0 1034 0 ✅ Unchanged

⚙️ sentry-frontend Snapshot Settings

@shashjar
shashjar force-pushed the shashjar/feat/iswf-3705-inbox-frequency branch from d5fc207 to 8c2ff58 Compare November 20, 2026 00:13
@shashjar
shashjar removed this pull request from stack #131096 November 20, 2026 00:15
@shashjar
shashjar added this pull request to stack #131948 November 20, 2026 00:15
@shashjar
shashjar force-pushed the shashjar/feat/iswf-3705-inbox-frequency branch 7 times, most recently from 68933b3 to 73db373 Compare November 20, 2026 22:21
Keep alert throttling per workflow/action association and record history only for eligible workflows.

Refs ISWF-3705
Exercise group-less eligibility with an unrestricted handler instead of setting the removed capability flag.

Refs ISWF-3705
Keep the frequency and history contracts concise and remove unused fixture state.

Refs ISWF-3705
@shashjar
shashjar force-pushed the shashjar/feat/iswf-3705-inbox-frequency branch from 73db373 to e48baa7 Compare November 20, 2026 23:07
Reject unsupported actions before writing group frequency state so a later supported event can still fire.

Refs ISWF-3705
Reuse the alert scenarios for Seer suppression and exclusion from group-less evaluations.

Refs ISWF-3705
Require callers to provide evaluated workflow eligibility while retaining organization-scoped history filtering.

Refs ISWF-3705
@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

decision-model-linter

api

src/sentry/workflow_engine/processors/workflow_fire_history.py

  • warn makesExistingInputStricter = TRUE (0.82): Rejecting input an endpoint accepted before, or changing a field's default, breaks existing callers, and the API spec often doesn't show it. Make the change backward compatible (keep the field optional, accept the old values, or keep the old default), or treat it as a breaking change and coordinate it.

decision-model-linter: 20 calls on 4 files, 50,105 input tokens, $0.0021, model typesafe/jev-1.13-20260917

Describe event validation before frequency and history, and Inbox-only eligibility without a group.

Refs ISWF-3705
@shashjar
shashjar requested review from a team November 21, 2026 17:48
@shashjar
shashjar marked this pull request as ready for review November 21, 2026 17:48

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant