Repository navigation
Reduce calculation overhead in people contract and filter lookups - #89
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are identified for the performance, return-contract, and version updates described.
No open issues 🎉
What changed in this PR
This pull request reduces calculation and group-membership lookup overhead while updating the application version to 1.2.10.
Changes:
- Simplifies the
People::YAML#readreturn contract. - Caches calculated group member IDs in a
Setfor faster membership checks. - Updates the application version in the source and lockfile.
| File | Description |
|---|---|
lib/version.rb |
Updates the application version to 1.2.10. |
lib/entitlements/data/people/yaml.rb |
Simplifies the full-read return contract. |
lib/entitlements/data/groups/calculated/filters/base.rb |
Uses a Set for cached group membership lookups. |
Gemfile.lock |
Synchronizes the locked application version. |
Review effort: Lite (auto)
nobe4
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small performance changes to group calculation, plus a version bump to 1.2.10.
People::YAML#read: the return contract checked every entry of the people hash on each call. The method builds and caches this hash itself, so the contract now checks only that aHashis returned.Filters::Base#member_of_named_group?: cache the group's members as aSetinstead of anArray, so membership checks no longer scan the whole list.In local profiling, calculation time roughly halved, and the resulting group membership was unchanged.
Tests:
bundle exec rspec spec/unitpasses (568 examples, 0 failures, 100% coverage).