fix(lint): dedupe CSS transform text in gsap_css_transform_conflict - #3761
Open
Abhishek-kumarsingh wants to merge 1 commit into
Open
Conversation
When one declaration (e.g. transform: scale(1.08) translate3d(1.5%, 0, 0))
matches both the translate and scale selector maps, cssFromTranslate and
cssFromScale end up equal, and join(" ") concatenated the identical string
with itself in both the finding message and fixHint.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LQXJUdfkq6CGWh6KNfVXyw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3263. In the
gsap_css_transform_conflictrule,cssTransformis built by joiningcssFromTranslateandcssFromScale. When a single CSS declaration matches both the translate and scale selector maps (e.g.transform: scale(1.08) translate3d(1.5%, 0, 0)), both variables resolve to the same full-transform string, and.join(" ")concatenates the identical string with itself — doubling the text in both the findingmessageandfixHint.Fix
Deduplicate before joining, as suggested in the issue:
Test plan
scale()/translate3d()declaration), confirmed it failed before the fix@hyperframes/lintsuite pass (607/607)oxlintandoxfmt --checkclean on changed files