Skip to content

fix(lint): dedupe CSS transform text in gsap_css_transform_conflict #3761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Abhishek-kumarsingh wants to merge 1 commit into
base: main
Choose a base branch
from
+26 −1
Open

fix(lint): dedupe CSS transform text in gsap_css_transform_conflict #3761

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions packages/lint/src/rules/gsap.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,6 +565,31 @@ describe("GSAP rules", () => {
expect(conflicts[0]?.message).toMatch(/x\/scale|scale\/x/);
});

it("does not duplicate the CSS transform text when one declaration matches both translate and scale", async () => {
const html = `
<html><body>
<div id="root" data-composition-id="c1" data-width="1920" data-height="1080">
<div id="scene-1" class="scene-1">hi</div>
</div>
<style>
.scene-1 { transform: scale(1.08) translate3d(1.5%, 0, 0); }
</style>
<script>
window.__timelines = window.__timelines || {};
const tl = gsap.timeline({ paused: true });
tl.to(".scene-1", { duration: 1, x: 100, scale: 1.2 });
window.__timelines["c1"] = tl;
</script>
</body></html>`;
const result = await lintHyperframeHtml(html);
const conflict = result.findings.find((f) => f.code === "gsap_css_transform_conflict");
expect(conflict).toBeDefined();
const doubled = "scale(1.08) translate3d(1.5%, 0, 0) scale(1.08) translate3d(1.5%, 0, 0)";
expect(conflict?.message).not.toContain(doubled);
expect(conflict?.fixHint).not.toContain(doubled);
expect(conflict?.message).toContain("transform: scale(1.08) translate3d(1.5%, 0, 0)");
});

// --- Inline style transform detection tests ---

it("warns when inline style transform: translateX conflicts with GSAP x", async () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/lint/src/rules/gsap.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1351,7 +1351,7 @@ export const gsapRules: LintRule<LintContext>[] = [
scaleProps.length > 0 ? matchCssTransform(sel, cssScaleSelectors) : undefined;
if (!cssFromTranslate && !cssFromScale) continue;
const existing = conflicts.get(sel) ?? {
cssTransform: [cssFromTranslate, cssFromScale].filter(Boolean).join(" "),
cssTransform: [...new Set([cssFromTranslate, cssFromScale].filter(Boolean))].join(" "),
props: new Set<string>(),
raw: call.raw,
};
Expand Down