Skip to content

fix(domains): no "none" domains; certificate errors in plain words - #145

Merged
hiddify-com merged 3 commits into
hiddify:devfrom
Hiddify-Official:fix/domain-cert-errors
Nov 1, 2026
Merged

hiddify-com merged 3 commits into
hiddify:devfrom
Hiddify-Official:fix/domain-cert-errors

Conversation

@Hiddify-Official

@Hiddify-Official Hiddify-Official commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Stacked on #152 (every domain row the same height): merge #152 first; until then this diff also shows its commit.

Problem

On a server whose public IPv4 was not found at its first setup (an IPv6-only server), the Domains page showed two domains, none and none.sslip.io, with Certificate failed and a raw ACME message. The failure never went away. Root cause: _v1 built the default domains from str(get_ip_str(4)), which is "None" when no IPv4 is found.

Separately, any certificate failure showed only the raw CA message, in a block that made that row twice as tall as the others. Rows also had different heights (with or without a line of chosen proxies, and the smaller fake-TLS fronts).

Change

  • panel/init_db.py
    • _default_domains(): the IPv4 and <IPv4>.sslip.io, else <IPv6>.sslip.io (exploded, :→-), else no domain. _v1 uses it.
    • _v191 (191 so it doesn't collide with feat(settings): new user position in General settings #121's _v190) removes none and none.sslip.io, clearing server_domain and show_domains references. Only if they are the server's only domains are the default names added first. It doesn't rename them to the looked-up IPv4: on the IPv6-only test node, v4.ident.me returned an egress address that does not reach the server.
  • features/domains/cert-error.ts: classifies the ACME error into one of: not a real domain name, a CAA record, DNS not pointing here, port 80 closed, the CA not answering, or other.
  • DomainsView.vue
    • The badge line shows the kind in a few words with Show more. Under the row, a card unfolds with a plain-words explanation, numbered steps, Try again, and the CA's message under Technical details.
    • Row heights: now in fix(domains): every domain row the same height #152, which this PR is stacked on.
    • New domains.certError.* strings in 7 languages.

Screenshots

The IPv6-only node's Domains page before, and after the migration ran:

Before After
before after

A failed certificate, closed by default with all rows the same height, and opened with Show more. The two errors were injected into the page's data for the screenshot.

Before After (closed) After (opened)
before closed open
Mobile before Mobile after
before after

Tested

  • node2 (IPv6-only, with none and none.sslip.io from its first setup), panel restart:
    • db_version went 190 → 191, the two domains were removed and its other 5 domains were kept.
    • The panel is active with no traceback.
    • main's synced copy of node2's domains dropped them too.
  • On node2, before the migration ran, the two real errors were classified as "Not a real domain name" and "The domain does not point to this server".
  • Measured row heights on main and node2: all rows are 87.4 px (the two error rows 87.7). On phones the cards match except one with both an error and the Get certificate button.
  • vue-tsc: no errors in the changed files.

Review

  • Confidence: Needs review — _v191 deletes domain rows. It only touches the literal names none and none.sslip.io and never leaves a server without a domain, but please check the reference clean-up against domains_page_api.delete. The port 80, CAA and CA-down texts are matched from known messages, not from failures seen on these servers.
  • Complexity: Complex — a migration plus a UI change.

Related: #121 also adds _v190.

🤖 Generated with Claude Code

A row without a line of chosen proxies was shorter than one with it (65 vs
87 px), and the fake-TLS front domains were drawn smaller. Every row's head
is now at least as tall as a row with that line, with its lines kept
together in the middle, so nothing moves inside a row; the fronts keep
their quieter look at the same size. Phones are unchanged (the cards were
already the same height there).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Hiddify-Official and others added 2 commits October 30, 2026 17:21
…ds certificate errors

The first setup named the server's default domains after
str(get_ip_str(4)): on a server whose public IPv4 was not found (an
IPv6-only server) that made "none" and "none.sslip.io", which never get a
certificate, so the Domains page showed "Certificate failed" on them for
good.

- _default_domains(): the IPv4 and <IPv4>.sslip.io, else <IPv6>.sslip.io,
  else none at all.
- _v191 removes "none" and "none.sslip.io"; only when they are the
  server's only domains do its default names take their place first.
- Domains page: a failed certificate says why in plain words (not a real
  domain name, the domain does not point here, port 80 closed, CAA record,
  the CA did not answer, other) with numbered steps; the CA's message is
  under Technical details.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The certificate error took a block under the row, so a row with an error
was twice as tall as the others. The badge line now says why in a few words
("Not a real domain name") with a "Show more" button; the full story
(plain-words lead, numbered steps, Try again, the CA's message under
Technical details) unfolds under the row in a card of its own, and "Show
less" closes it. Closed, the row keeps the height of the others (hiddify#152).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@hiddify-com
hiddify-com merged commit bc84fab into hiddify:dev Nov 1, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants