Repository navigation
fix(domains): no "none" domains; certificate errors in plain words - #145
Merged
Merged
Conversation
A row without a line of chosen proxies was shorter than one with it (65 vs 87 px), and the fake-TLS front domains were drawn smaller. Every row's head is now at least as tall as a row with that line, with its lines kept together in the middle, so nothing moves inside a row; the fronts keep their quieter look at the same size. Phones are unchanged (the cards were already the same height there). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ds certificate errors The first setup named the server's default domains after str(get_ip_str(4)): on a server whose public IPv4 was not found (an IPv6-only server) that made "none" and "none.sslip.io", which never get a certificate, so the Domains page showed "Certificate failed" on them for good. - _default_domains(): the IPv4 and <IPv4>.sslip.io, else <IPv6>.sslip.io, else none at all. - _v191 removes "none" and "none.sslip.io"; only when they are the server's only domains do its default names take their place first. - Domains page: a failed certificate says why in plain words (not a real domain name, the domain does not point here, port 80 closed, CAA record, the CA did not answer, other) with numbered steps; the CA's message is under Technical details. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The certificate error took a block under the row, so a row with an error
was twice as tall as the others. The badge line now says why in a few words
("Not a real domain name") with a "Show more" button; the full story
(plain-words lead, numbered steps, Try again, the CA's message under
Technical details) unfolds under the row in a card of its own, and "Show
less" closes it. Closed, the row keeps the height of the others (hiddify#152).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Hiddify-Official
force-pushed
the
fix/domain-cert-errors
branch
from
October 30, 2026 13:55
6a14f02 to
a609984
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On a server whose public IPv4 was not found at its first setup (an IPv6-only server), the Domains page showed two domains,
noneandnone.sslip.io, with Certificate failed and a raw ACME message. The failure never went away. Root cause:_v1built the default domains fromstr(get_ip_str(4)), which is"None"when no IPv4 is found.Separately, any certificate failure showed only the raw CA message, in a block that made that row twice as tall as the others. Rows also had different heights (with or without a line of chosen proxies, and the smaller fake-TLS fronts).
Change
panel/init_db.py_default_domains(): the IPv4 and<IPv4>.sslip.io, else<IPv6>.sslip.io(exploded,:→-), else no domain._v1uses it._v191(191 so it doesn't collide with feat(settings): new user position in General settings #121's_v190) removesnoneandnone.sslip.io, clearingserver_domainandshow_domainsreferences. Only if they are the server's only domains are the default names added first. It doesn't rename them to the looked-up IPv4: on the IPv6-only test node,v4.ident.mereturned an egress address that does not reach the server.features/domains/cert-error.ts: classifies the ACME error into one of: not a real domain name, a CAA record, DNS not pointing here, port 80 closed, the CA not answering, or other.DomainsView.vuedomains.certError.*strings in 7 languages.Screenshots
The IPv6-only node's Domains page before, and after the migration ran:
A failed certificate, closed by default with all rows the same height, and opened with Show more. The two errors were injected into the page's data for the screenshot.
Tested
noneandnone.sslip.iofrom its first setup), panel restart:db_versionwent 190 → 191, the two domains were removed and its other 5 domains were kept.vue-tsc: no errors in the changed files.Review
_v191deletes domain rows. It only touches the literal namesnoneandnone.sslip.ioand never leaves a server without a domain, but please check the reference clean-up againstdomains_page_api.delete. The port 80, CAA and CA-down texts are matched from known messages, not from failures seen on these servers.Related: #121 also adds
_v190.🤖 Generated with Claude Code