Repository navigation
fix(domains): every domain row the same height - #152
Merged
Merged
Conversation
A row without a line of chosen proxies was shorter than one with it (65 vs 87 px), and the fake-TLS front domains were drawn smaller. Every row's head is now at least as tall as a row with that line, with its lines kept together in the middle, so nothing moves inside a row; the fronts keep their quieter look at the same size. Phones are unchanged (the cards were already the same height there). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Hiddify-Official
added a commit
to Hiddify-Official/hiddifypanel
that referenced
this pull request
Oct 30, 2026
The certificate error took a block under the row, so a row with an error
was twice as tall as the others. The badge line now says why in a few words
("Not a real domain name") with a "Show more" button; the full story
(plain-words lead, numbered steps, Try again, the CA's message under
Technical details) unfolds under the row in a card of its own, and "Show
less" closes it. Closed, the row keeps the height of the others (hiddify#152).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On the Domains page the rows had different heights: a domain with a line of chosen proxies under its name was 87 px, one without it 65 px. The fake-TLS front domains (Telegram, ShadowTLS, SS FakeTLS) were drawn smaller as well.
Change
DomainsView.vue:.dm-row__headgetsmin-height: 4.7rem, the height of a row with the chosen-proxies line, so every row matches.align-content: centerkeeps the lines together in the middle: without it the extra room is shared out between the grid's rows, and the name drifts away from its badges..dm-row--minor: keeps only its quieter look (opacity). Its smaller padding, radius, icon and font are gone, so it is the same box as the others.min-height: 0in the phone layout). The cards were already the same height there, and the desktop minimum would only add empty room.Screenshots
Tested
Measured on main (and node2's own panel) with
getBoundingClientRect:Review
Related: #145 had a first version of this (min-height without
align-content, and a phone minimum). It is now stacked on this branch with the same lines.🤖 Generated with Claude Code