Skip to content

fix(domains): every domain row the same height - #152

Merged
hiddify-com merged 1 commit into
hiddify:devfrom
Hiddify-Official:fix/domain-row-height
Nov 1, 2026
Merged

hiddify-com merged 1 commit into
hiddify:devfrom
Hiddify-Official:fix/domain-row-height

Conversation

@Hiddify-Official

Copy link
Copy Markdown
Contributor

Problem

On the Domains page the rows had different heights: a domain with a line of chosen proxies under its name was 87 px, one without it 65 px. The fake-TLS front domains (Telegram, ShadowTLS, SS FakeTLS) were drawn smaller as well.

Change

  • DomainsView.vue: .dm-row__head gets min-height: 4.7rem, the height of a row with the chosen-proxies line, so every row matches. align-content: center keeps the lines together in the middle: without it the extra room is shared out between the grid's rows, and the name drifts away from its badges.
  • .dm-row--minor: keeps only its quieter look (opacity). Its smaller padding, radius, icon and font are gone, so it is the same box as the others.
  • Phones: no minimum (min-height: 0 in the phone layout). The cards were already the same height there, and the desktop minimum would only add empty room.

Screenshots

Before After
before after
before after

Tested

Measured on main (and node2's own panel) with getBoundingClientRect:

Before (px) After (px)
Desktop 65.3 / 87.3 87.4 for every row
Persian — 87.4 for every row
Phone 95.4 – 95.6 95.4 – 95.6 (unchanged)

Review

  • Confidence: High (>90%) — CSS only in one view, measured on the server.
  • Complexity: Simple — one stylesheet block.

Related: #145 had a first version of this (min-height without align-content, and a phone minimum). It is now stacked on this branch with the same lines.

🤖 Generated with Claude Code

A row without a line of chosen proxies was shorter than one with it (65 vs
87 px), and the fake-TLS front domains were drawn smaller. Every row's head
is now at least as tall as a row with that line, with its lines kept
together in the middle, so nothing moves inside a row; the fronts keep
their quieter look at the same size. Phones are unchanged (the cards were
already the same height there).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Hiddify-Official added a commit to Hiddify-Official/hiddifypanel that referenced this pull request Oct 30, 2026
The certificate error took a block under the row, so a row with an error
was twice as tall as the others. The badge line now says why in a few words
("Not a real domain name") with a "Show more" button; the full story
(plain-words lead, numbered steps, Try again, the CA's message under
Technical details) unfolds under the row in a card of its own, and "Show
less" closes it. Closed, the row keeps the height of the others (hiddify#152).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@hiddify-com
hiddify-com merged commit c390775 into hiddify:dev Nov 1, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants