Skip to content

Preserve explicit @RequestParam names when compiler metadata is unknown - #1179

Draft
SwatiKumari250 wants to merge 2 commits into
openrewrite:mainfrom
SwatiKumari250:fix/issue-736-implicit-web-annotation-names
Draft

SwatiKumari250 wants to merge 2 commits into
openrewrite:mainfrom
SwatiKumari250:fix/issue-736-implicit-web-annotation-names

Conversation

@SwatiKumari250

@SwatiKumari250 SwatiKumari250 commented Oct 11, 2026 •

Copy link
Copy Markdown

Summary

  • Avoid removing explicit @RequestParam names when the recipe cannot establish that Java parameter-name metadata is available.
  • Add regression coverage for a parameter whose explicit annotation name matches its Java variable name.

Motivation

Addresses the failure mode described in #736, where removing an explicit @RequestParam value can break applications compiled without -parameters.

Verification

This PR is opened as a draft because the Gradle test suite has not been run in this environment. Please review the conservative behavior change and run the focused test before treating this as ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

ImplicitWebAnnotationNames removes @RequestParam argument even when -parameters is missing

1 participant