Repository navigation
Preserve explicit @RequestParam names when compiler metadata is unknown - #1179
Draft
SwatiKumari250 wants to merge 2 commits into
Draft
SwatiKumari250 wants to merge 2 commits into
SwatiKumari250 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@RequestParamnames when the recipe cannot establish that Java parameter-name metadata is available.Motivation
Addresses the failure mode described in #736, where removing an explicit
@RequestParamvalue can break applications compiled without-parameters.Verification
This PR is opened as a draft because the Gradle test suite has not been run in this environment. Please review the conservative behavior change and run the focused test before treating this as ready for review.
ImplicitWebAnnotationNamesremoves@RequestParamargument even when-parametersis missing #736