Skip to content

Preserve explicit @RequestParam names when compiler metadata is unknown #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
SwatiKumari250 wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Preserve explicit @RequestParam names when compiler metadata is unknown #1179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29f5248
Avoid removing @RequestParam names without compiler metadata
SwatiKumari250 Oct 11, 2026
58548ac
Add regression coverage for implicit RequestParam names
SwatiKumari250 Oct 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/main/java/org/openrewrite/java/spring/ImplicitWebAnnotationNames.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ public TreeVisitor<?, ExecutionContext> getVisitor() {
private static class ImplicitWebAnnotationNamesVisitor extends JavaIsoVisitor<ExecutionContext> {
private static final Set<String> PARAM_ANNOTATIONS = Stream.of(
"PathVariable",
"RequestParam",
"RequestHeader",
"RequestAttribute",
"CookieValue",
Expand Down
6 changes: 3 additions & 3 deletions src/test/java/org/openrewrite/java/spring/ImplicitWebAnnotationNamesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,9 @@ public ResponseEntity<String> getUser(@PathVariable Long id,
);
}

@Issue("#4")
@Issue("https://github.com/openrewrite/rewrite-spring/issues/736")
@Test
void removeUnnecessarySpacingInFollowingAnnotationArgument() {
void preserveRequestParamNameWhenCompilerMetadataIsUnknown() {
//language=java
rewriteRun(
java(
Expand All @@ -106,7 +106,7 @@ public ResponseEntity<String> getUser(
public class UsersController {
@GetMapping("/{id}")
public ResponseEntity<String> getUser(
@RequestParam(defaultValue = 3) int count) {
@RequestParam(name = "count", defaultValue = 3) int count) {
}
}
"""
Expand Down