fix(status): detect incomplete cluster topology#178
Merged
Conversation
cxymds
marked this pull request as ready for review
July 23, 2026 02:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Make Running Status treat v4 cluster membership and pool topology as the authoritative denominator while retaining v3 server details.
The previous UI could render
Healthy,3/3servers, and3/0disks when v3 omitted one member buttotalDrivesPerSetand the v4 snapshot both expected four topology entries. The normalization layer discarded the v3 denominator and parsed v4 membership without using it in the presentation model.This change:
totalDrivesPerSetType of Change
Testing
pnpm install --frozen-lockfile pnpm test:run pnpm tsc --noEmit pnpm lint pnpm prettier --check . pnpm buildAll 359 tests pass and the production build completes successfully.
Checklist
Related Issues
Closes rustfs/backlog#1429
Screenshots (if applicable)
Not included. Local browser validation reached the permission guard because no RustFS backend/login session was available; data mapping, UI wiring, type checking, and the production build were verified locally.
Additional Notes
The v4 snapshot supplies the expected topology while v3 remains the source of version, uptime, drive usage, and network detail. When v4 is unavailable, the page falls back to the v3 drive denominator without inferring a server count from drive count.