Repository navigation
Fix Linux wheel illegal-instruction crashes - #511
Merged
Merged
Conversation
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
cjacoby-sptfy
marked this pull request as ready for review
September 21, 2026 20:25
caravanuden
approved these changes
Sep 22, 2026
caravanuden
left a comment
There was a problem hiding this comment.
looks good! just a couple questions
tdhopper
approved these changes
Sep 22, 2026
tdhopper
left a comment
Collaborator
There was a problem hiding this comment.
I reproduced the existing bug in docker and verified the changes resolve it.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #454 by preventing Linux x86_64 wheels from accidentally requiring CPU instructions newer than the project’s documented baseline.
The manylinux build previously used
-march=native. Because wheel builders may run on newer CPUs, this could compile host-specific instructions into the distributed wheel. On older CPUs, importingpedalboardcould then terminate withSIGILL(Illegal instruction).Changes
-mavx.USE_MARCH_NATIVE=1.pedalboardand process audio withGain.Validation
Native GCP machines
The exact manylinux x86_64 wheels produced by this PR’s CI run were tested on native GCP VMs using:
All CPython wheels from 3.10 through 3.15 successfully imported and processed audio on both machines: 12/12 passed.
As a negative control, the published
pedalboard==0.9.21CPython 3.11 wheel reproduced the original failure on both machines:This confirms that the test environments can detect the original incompatibility.
CI and local testing
The only non-passing job in the CI run was the macOS Python 3.15 test job, which timed out after six hours. It did not report a test failure and does not exercise the Linux wheel-building path changed here.